Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-15 Thread Laurent Vivier
On 15/11/2019 10:20, David Gibson wrote: > On Wed, Nov 13, 2019 at 05:00:40PM +0100, Greg Kurz wrote: >> On Wed, 13 Nov 2019 15:31:58 + >> Peter Maydell wrote: >> >>> On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote: David is away until the 19th of November, which is the release date o

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-15 Thread David Gibson
On Wed, Nov 13, 2019 at 05:00:40PM +0100, Greg Kurz wrote: > On Wed, 13 Nov 2019 15:31:58 + > Peter Maydell wrote: > > > On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote: > > > David is away until the 19th of November, which is the release date > > > of rc2 according to the planning [*]. Then w

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-13 Thread Greg Kurz
On Wed, 13 Nov 2019 15:31:58 + Peter Maydell wrote: > On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote: > > David is away until the 19th of November, which is the release date > > of rc2 according to the planning [*]. Then we have rc3 the 26th, and > > final release (or rc4) the 3rd of December

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-13 Thread Peter Maydell
On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote: > David is away until the 19th of November, which is the release date > of rc2 according to the planning [*]. Then we have rc3 the 26th, and > final release (or rc4) the 3rd of December, so it should be ok. Please don't actively plan to delay putting

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-13 Thread Greg Kurz
On Wed, 13 Nov 2019 15:43:44 +0100 Jiri Denemark wrote: > Hi David. > > On Wed, Oct 30, 2019 at 17:32:43 +0100, David Gibson wrote: > > We have to set the default model of all machine classes, not just for the > > active one. Otherwise, "query-machines" will indicate the wrong CPU model > > ("qe

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-13 Thread Jiri Denemark
Hi David. On Wed, Oct 30, 2019 at 17:32:43 +0100, David Gibson wrote: > We have to set the default model of all machine classes, not just for the > active one. Otherwise, "query-machines" will indicate the wrong CPU model > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". > >

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-01 Thread Jiri Denemark
On Wed, Oct 30, 2019 at 17:32:43 +0100, David Gibson wrote: > We have to set the default model of all machine classes, not just for the > active one. Otherwise, "query-machines" will indicate the wrong CPU model > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". > > s390x alre

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread David Gibson
On Thu, Oct 31, 2019 at 09:15:56AM +0100, Greg Kurz wrote: > On Wed, 30 Oct 2019 17:32:43 +0100 > David Gibson wrote: > > > We have to set the default model of all machine classes, not just for the > > active one. Otherwise, "query-machines" will indicate the wrong CPU model > > ("qemu-s390x-cpu"

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread David Gibson
On Wed, Oct 30, 2019 at 06:32:28PM +0100, David Hildenbrand wrote: > On 30.10.19 17:32, David Gibson wrote: > > We have to set the default model of all machine classes, not just for the > > active one. Otherwise, "query-machines" will indicate the wrong CPU model > > ("qemu-s390x-cpu" instead of "h

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread Peter Maydell
On Thu, 31 Oct 2019 at 08:28, Peter Maydell wrote: > Isn't this a bug in libvirt ? The default CPU for one machine type > tells you nothing at all about the default machine for another CPU > type. Libvirt needs to ask about the default CPU for the machine > it's actually interested in, which is no

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread Peter Maydell
On Wed, 30 Oct 2019 at 16:34, David Gibson wrote: > > We have to set the default model of all machine classes, not just for the > active one. Otherwise, "query-machines" will indicate the wrong CPU model > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". > > s390x already fixe

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-31 Thread Greg Kurz
On Wed, 30 Oct 2019 17:32:43 +0100 David Gibson wrote: > We have to set the default model of all machine classes, not just for the > active one. Otherwise, "query-machines" will indicate the wrong CPU model > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". > A PPC cpu mode

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191030163243.10644-1-da...@gibson.dropbear.id.au/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191030163243.10644-1-da...@gibson.dropbear.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] spapr/kvm: Set default cpu model for all machine classes Type: series Message-id

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-30 Thread David Hildenbrand
On 30.10.19 17:32, David Gibson wrote: We have to set the default model of all machine classes, not just for the active one. Otherwise, "query-machines" will indicate the wrong CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". Maybe use ppc CPU models here instead

[PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-10-30 Thread David Gibson
We have to set the default model of all machine classes, not just for the active one. Otherwise, "query-machines" will indicate the wrong CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type". s390x already fixed this in de60a92e "s390x/kvm: Set default cpu model for all m