RE: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-07-22 Thread Duan, Zhenzhong
>-Original Message- >From: David Hildenbrand >Sent: Friday, July 22, 2022 2:49 PM >To: Duan, Zhenzhong ; qemu- >de...@nongnu.org >Cc: pbonz...@redhat.com; pet...@redhat.com; f4...@amsat.org >Subject: Re: [PATCH] softmmu/physmem: Fix input parameters for >flatvie

Re: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-07-22 Thread David Hildenbrand
On 22.06.22 03:28, Zhenzhong Duan wrote: > The comment of flatview_access_allowed() suggests to pass address > within that memory region, this isn't ture in some call sites. s/ture/true/ > > This makes qemu log in flatview_access_allowed() confusing and > potential risk if the input parameter wi

RE: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-07-21 Thread Duan, Zhenzhong
>-Original Message- >From: Peter Xu >Sent: Thursday, June 23, 2022 5:03 AM >To: Duan, Zhenzhong >Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; da...@redhat.com; >f4...@amsat.org >Subject: Re: [PATCH] softmmu/physmem: Fix input parameters for >flatview_access_

Re: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-06-22 Thread Peter Xu
On Wed, Jun 22, 2022 at 09:28:39AM +0800, Zhenzhong Duan wrote: > The comment of flatview_access_allowed() suggests to pass address > within that memory region, this isn't ture in some call sites. > > This makes qemu log in flatview_access_allowed() confusing and > potential risk if the input para

[PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-06-21 Thread Zhenzhong Duan
The comment of flatview_access_allowed() suggests to pass address within that memory region, this isn't ture in some call sites. This makes qemu log in flatview_access_allowed() confusing and potential risk if the input parameter will be checked in the future. Fixes: 3ab6fdc91b72 ("softmmu/physme