Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Wed, 15 Nov 2023 at 17:26, Patrick Venture wrote: > > > > On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson > wrote: >> >> On 11/15/23 08:58, Patrick Venture wrote: >> > >> > >> > On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell > > > wrote: >> > >> > On Tue,

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Wed, Nov 15, 2023 at 9:26 AM Patrick Venture wrote: > > > On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 11/15/23 08:58, Patrick Venture wrote: >> > >> > >> > On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell > >

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/15/23 08:58, Patrick Venture wrote: > > > > > > On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell > > wrote: > > > > On Tue, 14 Nov 2023 at 20:55, Patrick Venture >

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On 11/15/23 08:58, Patrick Venture wrote: On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell > wrote: On Tue, 14 Nov 2023 at 20:55, Patrick Venture mailto:vent...@google.com>> wrote: > Avoids unaligned pointer issues. > It would be nice to be mor

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell wrote: > On Tue, 14 Nov 2023 at 20:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > It would be nice to be more specific in the commit message here, by > describing what kind of guest behaviour or machine config runs into this

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Wed, Nov 15, 2023 at 2:30 AM Peter Maydell wrote: > On Tue, 14 Nov 2023 at 21:18, Richard Henderson > wrote: > > > > On 11/14/23 12:55, Patrick Venture wrote: > > > Avoids unaligned pointer issues. > > > > > > Reviewed-by: Chris Rauer > > > Reviewed-by: Peter Foley > > > Signed-off-by: Patr

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Tue, 14 Nov 2023 at 20:55, Patrick Venture wrote: > Avoids unaligned pointer issues. > It would be nice to be more specific in the commit message here, by describing what kind of guest behaviour or machine config runs into this problem, and whether this happens in a situation users are likely

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Tue, 14 Nov 2023 at 21:18, Richard Henderson wrote: > > On 11/14/23 12:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > Reviewed-by: Chris Rauer > > Reviewed-by: Peter Foley > > Signed-off-by: Patrick Venture > > --- > > system/memory.c | 16 > > 1

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On Tue, Nov 14, 2023 at 1:18 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/14/23 12:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > Reviewed-by: Chris Rauer > > Reviewed-by: Peter Foley > > Signed-off-by: Patrick Venture > > --- > > system/memory.

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

On 11/14/23 12:55, Patrick Venture wrote: Avoids unaligned pointer issues. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture --- system/memory.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system/memory.c b/system/memo

[PATCH] softmmu/memory: use memcpy for multi-byte accesses

Avoids unaligned pointer issues. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture --- system/memory.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system/memory.c b/system/memory.c index 304fa843ea..02c97d5187 100644 --- a