Re: [PATCH] sockets: Use SOMAXCONN for Unix socket listen()

2021-02-05 Thread Eric Blake
On 2/5/21 3:55 AM, Daniel P. Berrangé wrote: >> +++ b/util/qemu-sockets.c >> @@ -1059,7 +1059,7 @@ int unix_listen(const char *str, Error **errp) >> >> saddr = g_new0(UnixSocketAddress, 1); >> saddr->path = g_strdup(str); >> -sock = unix_listen_saddr(saddr, 1, errp); >> +sock = u

Re: [PATCH] sockets: Use SOMAXCONN for Unix socket listen()

2021-02-05 Thread Richard W.M. Jones
On Thu, Feb 04, 2021 at 04:20:18PM -0600, Eric Blake wrote: > Our default of a backlog of 1 connection is rather puny, particularly > for scenarios where we expect multiple listeners to connect (such as > qemu-nbd -e X). For Unix sockets, there's no real harm in supporting > a larger backlog, and

Re: [PATCH] sockets: Use SOMAXCONN for Unix socket listen()

2021-02-05 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 04:20:18PM -0600, Eric Blake wrote: > Our default of a backlog of 1 connection is rather puny, particularly > for scenarios where we expect multiple listeners to connect (such as > qemu-nbd -e X). For Unix sockets, there's no real harm in supporting > a larger backlog, and

[PATCH] sockets: Use SOMAXCONN for Unix socket listen()

2021-02-04 Thread Eric Blake
Our default of a backlog of 1 connection is rather puny, particularly for scenarios where we expect multiple listeners to connect (such as qemu-nbd -e X). For Unix sockets, there's no real harm in supporting a larger backlog, and a definite benefit to the clients: at least on Linux, a client tryin