Re: [PATCH] smbios: Fix buffer overrun when using path= option

On Mon, Mar 24, 2025 at 07:24:59AM +0100, Thomas Huth wrote: > On 23/03/2025 22.35, Daan De Meyer wrote: > > We have to make sure the array of bytes read from the path= file > > is null-terminated, otherwise we run into a buffer overrun later on. > > > > Fixes: bb99f4772f54017490e3356ecbb3df25c5d4

Re: [PATCH] smbios: Fix buffer overrun when using path= option

Hi Daan, On 3/4/25 21:29, Daan De Meyer wrote: Hi, Unless I'm missing something, I don't think the patch has been merged yet. Any chance it might have been missed? I have it tagged, as sensible enough, in case nobody else takes it. IIRC it was sent the same day I posted my latest pull request

Re: [PATCH] smbios: Fix buffer overrun when using path= option

+Valentin On 23/3/25 22:35, Daan De Meyer wrote: We have to make sure the array of bytes read from the path= file is null-terminated, otherwise we run into a buffer overrun later on. Fixes: bb99f4772f54017490e3356ecbb3df25c5d4537f ("hw/smbios: support loading OEM strings values from a file") R

Re: [PATCH] smbios: Fix buffer overrun when using path= option

On 4/4/25 16:46, Valentin David wrote: On Thu, Apr 3, 2025 at 9:37 PM Philippe Mathieu-Daudé > wrote: Also I was hoping I could get feedback from Valentin. Sorry, I did not realize that you wanted my feedback. Daan's patch looks fine to me. I have manually tested

Re: [PATCH] smbios: Fix buffer overrun when using path= option

On Thu, Apr 3, 2025 at 9:37 PM Philippe Mathieu-Daudé wrote: > Also I was hoping I could get feedback from Valentin. > > Sorry, I did not realize that you wanted my feedback. Daan's patch looks fine to me. I have manually tested it and it fixes my issue.

Re: [PATCH] smbios: Fix buffer overrun when using path= option

Yes. On Fri, Apr 4, 2025 at 5:02 PM Philippe Mathieu-Daudé wrote: > On 4/4/25 16:46, Valentin David wrote: > > On Thu, Apr 3, 2025 at 9:37 PM Philippe Mathieu-Daudé > > wrote: > > > > Also I was hoping I could get feedback from Valentin. > > > > > > Sorry, I did no

Re: [PATCH] smbios: Fix buffer overrun when using path= option

Hi, Unless I'm missing something, I don't think the patch has been merged yet. Any chance it might have been missed? Cheers, Daan On Sun, 23 Mar 2025 at 22:36, Daan De Meyer wrote: > > We have to make sure the array of bytes read from the path= file > is null-terminated, otherwise we run into

Re: [PATCH] smbios: Fix buffer overrun when using path= option

CC qemu-stable - this needs cherry-picking into all active stable branches once accepted. On Mon, Mar 24, 2025 at 09:12:53AM +, Daniel P. Berrangé wrote: > On Sun, Mar 23, 2025 at 10:35:54PM +0100, Daan De Meyer wrote: > > We have to make sure the array of bytes read from the path= file > > is

Re: [PATCH] smbios: Fix buffer overrun when using path= option

On Sun, Mar 23, 2025 at 10:35:54PM +0100, Daan De Meyer wrote: > We have to make sure the array of bytes read from the path= file > is null-terminated, otherwise we run into a buffer overrun later on. > > Fixes: bb99f4772f54017490e3356ecbb3df25c5d4537f ("hw/smbios: support loading > OEM strings v

Re: [PATCH] smbios: Fix buffer overrun when using path= option

On 23/03/2025 22.35, Daan De Meyer wrote: We have to make sure the array of bytes read from the path= file is null-terminated, otherwise we run into a buffer overrun later on. Fixes: bb99f4772f54017490e3356ecbb3df25c5d4537f ("hw/smbios: support loading OEM strings values from a file") Resolves:

[PATCH] smbios: Fix buffer overrun when using path= option

We have to make sure the array of bytes read from the path= file is null-terminated, otherwise we run into a buffer overrun later on. Fixes: bb99f4772f54017490e3356ecbb3df25c5d4537f ("hw/smbios: support loading OEM strings values from a file") Resolves: https://gitlab.com/qemu-project/qemu/-/issu