Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-07-01 Thread Alberto Garcia
On Mon 01 Jul 2024 02:07:01 PM +03, Manos Pitsidianakis wrote: >> and I'm not sure what benefits using pathlib brings in this case. > > implicit type requirement, argument value validations, path > normalization etc. Do you have a specific example? I don't see any difference in behavior if I make

Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-07-01 Thread Manos Pitsidianakis
Hi Berto :) On Mon, 1 Jul 2024 at 11:56, Alberto Garcia wrote: > > On Wed 12 Jun 2024 02:00:19 PM +03, Manos Pitsidianakis wrote: > > Hi, thanks for the review and sorry for taking so long to reply, I was > on vacation. > > >> scripts/qcow2-to-stdout.py | 330 +

Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-07-01 Thread Alberto Garcia
On Wed 12 Jun 2024 02:00:19 PM +03, Manos Pitsidianakis wrote: Hi, thanks for the review and sorry for taking so long to reply, I was on vacation. >> scripts/qcow2-to-stdout.py | 330 + >> 1 file changed, 330 insertions(+) >> create mode 100755 scripts/qcow2-to-

Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-06-12 Thread Manos Pitsidianakis
On Wed, 12 Jun 2024 12:21, Alberto Garcia wrote: On Wed 12 Jun 2024 09:01:01 AM +03, Manos Pitsidianakis wrote: Hello Alberto, Hello Manos! > This is equivalent to using qemu-img to convert a file to qcow2 and > then writing the result to stdout, with the difference that this > tool does no

Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-06-12 Thread Manos Pitsidianakis
On Mon, 10 Jun 2024 17:47, Alberto Garcia wrote: This tool converts a disk image to qcow2, writing the result directly to stdout. This can be used for example to send the generated file over the network. This is equivalent to using qemu-img to convert a file to qcow2 and then writing the result

Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-06-12 Thread Alberto Garcia
On Wed 12 Jun 2024 09:01:01 AM +03, Manos Pitsidianakis wrote: > Hello Alberto, Hello Manos! > > This is equivalent to using qemu-img to convert a file to qcow2 and > > then writing the result to stdout, with the difference that this > > tool does not need to create this temporary qcow2 file and

Re: [PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-06-11 Thread Manos Pitsidianakis
Hello Alberto, On Mon, 10 Jun 2024 17:47, Alberto Garcia wrote: This tool converts a disk image to qcow2, writing the result directly to stdout. This can be used for example to send the generated file over the network. This is equivalent to using qemu-img to convert a file to qcow2 and then wr

[PATCH] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-06-10 Thread Alberto Garcia
This tool converts a disk image to qcow2, writing the result directly to stdout. This can be used for example to send the generated file over the network. This is equivalent to using qemu-img to convert a file to qcow2 and then writing the result to stdout, with the difference that this tool does