Re: [PATCH] rust: hpet: fix decoding of timer registers

2025-04-05 Thread Paolo Bonzini
On Fri, Mar 21, 2025 at 3:26 PM Peter Maydell wrote: > Tested-by: Peter Maydell > Reviewed-by: Peter Maydell > > If I understand the code correctly I think you could also > write this as "addr & 0x1f" which might be a little nicer > as it then lines up with the "/ 0x20". Yeah, I was undecided b

Re: [PATCH] rust: hpet: fix decoding of timer registers

2025-04-05 Thread Peter Maydell
On Fri, 21 Mar 2025 at 13:33, Paolo Bonzini wrote: > > Due to a missing "& 0x18", timer registers are not decoded correctly. > This breaks the tests/functional/test_x86_64_tuxrun.py functional > test. > > Fixes: 519088b7cf6 ("rust: hpet: decode HPET registers into enums", > 2025-03-06) > Reported

[PATCH] rust: hpet: fix decoding of timer registers

2025-03-21 Thread Paolo Bonzini
Due to a missing "& 0x18", timer registers are not decoded correctly. This breaks the tests/functional/test_x86_64_tuxrun.py functional test. Fixes: 519088b7cf6 ("rust: hpet: decode HPET registers into enums", 2025-03-06) Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- rust/hw/timer