Re: [PATCH] roms: add back edk2-basetools target

2023-07-12 Thread Olaf Hering
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann : > +++ b/roms/Makefile > +edk2-basetools: > + python3 edk2-build.py --config edk2-build.config -m none I think that needs to be $(PYTHON), because plain 'python3' may not be the required python version. In addition, a global EDK2_OPTIONS may al

Re: [PATCH] roms: add back edk2-basetools target

2023-04-11 Thread Gerd Hoffmann
On Tue, Apr 11, 2023 at 12:26:47PM +0200, Olaf Hering wrote: > Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann : > > > + python3 edk2-build.py --config edk2-build.config -m none > > Is '-m none' correct? Yes. BaseTools are built no matter what because any edk2 stuff depends on them. take care,

Re: [PATCH] roms: add back edk2-basetools target

2023-04-11 Thread Olaf Hering
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann : > + python3 edk2-build.py --config edk2-build.config -m none Is '-m none' correct? I think previously the result was just a native build. Now that introduced .config attempts cross builds. Maybe that detail must be mentioned in the release not

[PATCH] roms: add back edk2-basetools target

2023-04-11 Thread Gerd Hoffmann
The efi nic boot rom builds depend on this, they need the EfiRom utility from edk2 BaseTools. Fixes: 22e11539e167 ("edk2: replace build scripts") Reported-by: Olaf Hering Signed-off-by: Gerd Hoffmann --- roms/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roms/Makefile b/roms/M