Re: [PATCH] riscv: Set xPIE to 1 after xRET

2020-01-03 Thread Alistair Francis
On Fri, Jan 3, 2020 at 12:01 AM Yiting Wang wrote: > > When executing an xRET instruction, supposing xPP holds the > value y, xIE is set to xPIE; the privilege mode is changed to y; > xPIE is set to 1. But QEMU sets xPIE to 0 incorrectly. > > Signed-off-by: Yiting Wang Reviewed-by: Alistair Fran

Re: [PATCH] riscv: Set xPIE to 1 after xRET

2020-01-03 Thread Bin Meng
On Fri, Jan 3, 2020 at 4:03 PM Yiting Wang wrote: > > When executing an xRET instruction, supposing xPP holds the > value y, xIE is set to xPIE; the privilege mode is changed to y; > xPIE is set to 1. But QEMU sets xPIE to 0 incorrectly. > > Signed-off-by: Yiting Wang > --- > target/riscv/op_hel

[PATCH] riscv: Set xPIE to 1 after xRET

2020-01-03 Thread Yiting Wang
When executing an xRET instruction, supposing xPP holds the value y, xIE is set to xPIE; the privilege mode is changed to y; xPIE is set to 1. But QEMU sets xPIE to 0 incorrectly. Signed-off-by: Yiting Wang --- target/riscv/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d