Re: [PATCH] replication: compile out some staff when replication is not configured

On 11.04.23 17:51, Vladimir Sementsov-Ogievskiy wrote: Don't compile-in replication-related files when replication is disabled in config. Signed-off-by: Vladimir Sementsov-Ogievskiy v2 will be called "[PATCH v2 0/4] COLO: improve build options" -- Best regards, Vladimir

Re: [PATCH] replication: compile out some staff when replication is not configured

staff when replication is not configured On 14.04.23 04:24, Zhang, Chen wrote: So, if I want to have an option to disable all COLO modules, do you mean it should be additional --disable-colo option? Or better keep one option -- disable-replication (and, maybe just rename to to --disable- colo

Re: [PATCH] replication: compile out some staff when replication is not configured

...@redhat.com; quint...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, Hailiang ; lizhij...@fujitsu.com; wencongya...@huawei.com; xiechanglon...@gmail.com; den- plotni...@yandex-team.ru Subject: Re: [PATCH] replication: compile out some staff when replication is not configured On 14.04.23 04

RE: [PATCH] replication: compile out some staff when replication is not configured

edhat.com; > quint...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, > Hailiang ; lizhij...@fujitsu.com; > wencongya...@huawei.com; xiechanglon...@gmail.com; den- > plotni...@yandex-team.ru > Subject: Re: [PATCH] replication: compile out some staff when replication is > not conf

Re: [PATCH] replication: compile out some staff when replication is not configured

On 14.04.23 04:24, Zhang, Chen wrote: So, if I want to have an option to disable all COLO modules, do you mean it should be additional --disable-colo option? Or better keep one option -- disable-replication (and, maybe just rename to to --disable-colo)? I think keep the option --disable-replicat

RE: [PATCH] replication: compile out some staff when replication is not configured

otni...@yandex-team.ru > Subject: Re: [PATCH] replication: compile out some staff when replication is > not configured > > On 13.04.23 12:52, Zhang, Chen wrote: > > > > > >> -Original Message- > >> From: Vladimir Sementsov-Ogievskiy > >>

Re: [PATCH] replication: compile out some staff when replication is not configured

; quint...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, Hailiang ; Zhang, Chen ; lizhij...@fujitsu.com; wencongya...@huawei.com; xiechanglon...@gmail.com; den- plotni...@yandex-team.ru; Vladimir Sementsov-Ogievskiy Subject: [PATCH] replication: compile out some staff when replication is

RE: [PATCH] replication: compile out some staff when replication is not configured

nt...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, > Hailiang ; Zhang, Chen > ; lizhij...@fujitsu.com; > wencongya...@huawei.com; xiechanglon...@gmail.com; den- > plotni...@yandex-team.ru; Vladimir Sementsov-Ogievskiy > > Subject: [PATCH] replication: compile

Re: [PATCH] replication: compile out some staff when replication is not configured

Just a few minor nits On 4/11/23 5:51 PM, Vladimir Sementsov-Ogievskiy wrote: Don't compile-in replication-related files when replication is disabled in config. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! I'm unsure, should it be actually separate --disable-colo / --enable-colo o

[PATCH] replication: compile out some staff when replication is not configured

Don't compile-in replication-related files when replication is disabled in config. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! I'm unsure, should it be actually separate --disable-colo / --enable-colo options or it's really used only together with replication staff.. So, I decided t