Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Paolo Bonzini
On 18/05/21 12:57, Markus Armbruster wrote: Paolo Bonzini writes: On 18/05/21 10:54, Markus Armbruster wrote: Paolo Bonzini writes: These headers are also included from softmmu/vl.c, so they should be in include/. Removing qemu-options-wrapper.h, since elsewhere we include "template" head

Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/05/21 10:54, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> These headers are also included from softmmu/vl.c, so they should be >>> in include/. Removing qemu-options-wrapper.h, since elsewhere >>> we include "template" headers directly and #define the

Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Paolo Bonzini
On 18/05/21 10:54, Markus Armbruster wrote: Paolo Bonzini writes: These headers are also included from softmmu/vl.c, so they should be in include/. Removing qemu-options-wrapper.h, since elsewhere we include "template" headers directly and #define the parameters in the including file, and mov

Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Markus Armbruster
Paolo Bonzini writes: > These headers are also included from softmmu/vl.c, so they should be > in include/. Removing qemu-options-wrapper.h, since elsewhere > we include "template" headers directly and #define the parameters in > the including file, and move qemu-options.h to include/. > > Signe

Re: [PATCH] remove qemu-options* from root directory

2021-05-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210517121908.2624991-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517121908.2624991-1-pbonz...@redhat.com Subject: [PATCH] remove qemu-options

[PATCH] remove qemu-options* from root directory

2021-05-17 Thread Paolo Bonzini
These headers are also included from softmmu/vl.c, so they should be in include/. Removing qemu-options-wrapper.h, since elsewhere we include "template" headers directly and #define the parameters in the including file, and move qemu-options.h to include/. Signed-off-by: Paolo Bonzini --- qemu-