Re: [PATCH] qxl: fix segfault

2020-11-26 Thread Gerd Hoffmann
Hi, > > It would be nice to include this regression fix in the release. Anyone > > taking the patch to PR? > > Looks like a safe fix and we do need to roll rc4 anyway, so if somebody wants > to send a pullreq tomorrow I can apply it. I had one prepared already and was waiting for ci. Sent no

Re: [PATCH] qxl: fix segfault

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 15:42, Marc-André Lureau wrote: > > Hi > > On Tue, Nov 24, 2020 at 4:30 PM Gerd Hoffmann wrote: >> >> Add missing sanity check. >> Reproducer: run qemu with "-device qxl" but without "-spice ..." >> >> Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine"

Re: [PATCH] qxl: fix segfault

2020-11-26 Thread Marc-André Lureau
Hi On Tue, Nov 24, 2020 at 4:30 PM Gerd Hoffmann wrote: > Add missing sanity check. > Reproducer: run qemu with "-device qxl" but without "-spice ..." > > Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine") > Signed-off-by: Gerd Hoffmann > It would be nice to include this

Re: [PATCH] qxl: fix segfault

2020-11-24 Thread Marc-André Lureau
Hi On Tue, Nov 24, 2020 at 4:30 PM Gerd Hoffmann wrote: > Add missing sanity check. > Reproducer: run qemu with "-device qxl" but without "-spice ..." > > Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine") > Signed-off-by: Gerd Hoffmann > --- > ui/console.c | 4 +++- > 1

[PATCH] qxl: fix segfault

2020-11-24 Thread Gerd Hoffmann
Add missing sanity check. Reproducer: run qemu with "-device qxl" but without "-spice ..." Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine") Signed-off-by: Gerd Hoffmann --- ui/console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/console.c b