Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-10-11 Thread Juan Quintela
Thomas Huth wrote: > On 28/09/2023 15.32, Fabiano Rosas wrote: >> Thomas Huth writes: >> >>> On 27/09/2023 23.47, Fabiano Rosas wrote: Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. >>

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-10-05 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Sep 27, 2023 at 06:47:56PM -0300, Fabiano Rosas wrote: >> I know this adds a python dependency to qtests and I'm not sure how >> much we care about this script, but on the other hand it would be nice >> to catch these errors early on. >> >> This would also help with fu

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-10-04 Thread Peter Xu
On Wed, Sep 27, 2023 at 06:47:56PM -0300, Fabiano Rosas wrote: > I know this adds a python dependency to qtests and I'm not sure how > much we care about this script, but on the other hand it would be nice > to catch these errors early on. > > This would also help with future work that touches the

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-28 Thread Fabiano Rosas
Thomas Huth writes: > On 28/09/2023 15.32, Fabiano Rosas wrote: >> Thomas Huth writes: >> >>> On 27/09/2023 23.47, Fabiano Rosas wrote: Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags.

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-28 Thread Thomas Huth
On 28/09/2023 15.32, Fabiano Rosas wrote: Thomas Huth writes: On 27/09/2023 23.47, Fabiano Rosas wrote: Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way ha

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-28 Thread Fabiano Rosas
Thomas Huth writes: > On 27/09/2023 23.47, Fabiano Rosas wrote: >> Add a smoke test that migrates to a file and gives it to the >> script. It should catch the most annoying errors such as changes in >> the ram flags. >> >> After code has been merged it becomes way harder to figure out what is >>

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-27 Thread Thomas Huth
On 27/09/2023 23.47, Fabiano Rosas wrote: Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-27 Thread Fabiano Rosas
Fabiano Rosas writes: > Add a smoke test that migrates to a file and gives it to the > script. It should catch the most annoying errors such as changes in > the ram flags. > > After code has been merged it becomes way harder to figure out what is > causing the script to fail, the person making th

[PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-27 Thread Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person making the change is the most likely to know