Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
On 3/9/2020 6:15 PM, Daniel P. Berrangé wrote: > On Mon, Mar 09, 2020 at 10:51:45AM +0100, Igor Mammedov wrote: >> On Mon, 9 Mar 2020 17:22:12 +0800 >> Pan Nengyuan wrote: >> >>> 'type/id' forgot to free in qmp_object_add, this patch fix that. >>> >>> The leak stack: >>> Direct leak of 84 byte(

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
On 3/9/2020 5:51 PM, Igor Mammedov wrote: > On Mon, 9 Mar 2020 17:22:12 +0800 > Pan Nengyuan wrote: > >> 'type/id' forgot to free in qmp_object_add, this patch fix that. >> >> The leak stack: >> Direct leak of 84 byte(s) in 6 object(s) allocated from: >> #0 0x7fe2a5ebf768 in __interceptor_

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Daniel P . Berrangé
On Mon, Mar 09, 2020 at 10:51:45AM +0100, Igor Mammedov wrote: > On Mon, 9 Mar 2020 17:22:12 +0800 > Pan Nengyuan wrote: > > > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > > > The leak stack: > > Direct leak of 84 byte(s) in 6 object(s) allocated from: > > #0 0x7fe2a5

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Markus Armbruster
Cc'ing Kevin in the hope of a review. Pan Nengyuan writes: > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > The leak stack: > Direct leak of 84 byte(s) in 6 object(s) allocated from: > #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) > #1 0x7f

Re: [PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Igor Mammedov
On Mon, 9 Mar 2020 17:22:12 +0800 Pan Nengyuan wrote: > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > The leak stack: > Direct leak of 84 byte(s) in 6 object(s) allocated from: > #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) > #1 0x7fe2a50

[PATCH] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
'type/id' forgot to free in qmp_object_add, this patch fix that. The leak stack: Direct leak of 84 byte(s) in 6 object(s) allocated from: #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) #1 0x7fe2a505 in g_malloc (/lib64/libglib-2.0.so.0+0x52445) #2 0x7fe2a50