Re: [PATCH] qom/object: Remove circular include dependency

2022-06-28 Thread Laurent Vivier
Le 09/05/2022 à 10:46, Philippe Mathieu-Daudé a écrit : From: Philippe Mathieu-Daudé "qom/object.h" doesn't need to include itself. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h

Re: [PATCH] qom/object: Remove circular include dependency

2022-05-09 Thread Peter Maydell
On Mon, 9 May 2022 at 13:44, Philippe Mathieu-Daudé wrote: > > On 9/5/22 11:41, Peter Maydell wrote: > > Accidentally (but harmlessly) > > This makes crash clang tools such clang-format, I'll amend that > to the description. That sounds like a bug in clang-format :-) -- PMM

Re: [PATCH] qom/object: Remove circular include dependency

2022-05-09 Thread Philippe Mathieu-Daudé via
On 9/5/22 11:41, Peter Maydell wrote: On Mon, 9 May 2022 at 09:53, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé "qom/object.h" doesn't need to include itself. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 1 - 1 file changed, 1 deletion(-) diff --git a/

Re: [PATCH] qom/object: Remove circular include dependency

2022-05-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > From: Philippe Mathieu-Daudé > > "qom/object.h" doesn't need to include itself. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qom/object.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/qom/object.h b/include/qom/object.h > index 5f

Re: [PATCH] qom/object: Remove circular include dependency

2022-05-09 Thread Peter Maydell
On Mon, 9 May 2022 at 09:53, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > "qom/object.h" doesn't need to include itself. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qom/object.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/qom/object.h b/in

Re: [PATCH] qom/object: Remove circular include dependency

2022-05-09 Thread Damien Hedde
On 5/9/22 10:46, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé "qom/object.h" doesn't need to include itself. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Damien Hedde --- include/qom/object.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qom/object.h

[PATCH] qom/object: Remove circular include dependency

2022-05-09 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé "qom/object.h" doesn't need to include itself. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 5f3d5b5bf5..ef7258a5e1 100644 --- a/include/qom/object