Re: [PATCH] qga: skip bind mounts in fs list

2024-11-26 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk I will merge it into the next QEMU release. On Mon, Oct 28, 2024 at 2:15 PM Jean-Louis Dupond wrote: > Hi Konstantin, > > Thanks for your response. > What I observed was when running CloudLinux is that with a /tmp on a loop > device, is that the underlying fs wa

Re: [PATCH] qga: skip bind mounts in fs list

2024-10-28 Thread Jean-Louis Dupond
Hi Konstantin, Thanks for your response. What I observed was when running CloudLinux is that with a /tmp on a loop device, is that the underlying fs was first freezed, and then the /tmp was getting a freeze call. But this was hanging, because it couldn't freeze as the underlying fs was already

Re: [PATCH] qga: skip bind mounts in fs list

2024-10-28 Thread Konstantin Kostiuk
Hi Jean-Louis, Thanks for your patch. I hope next week, I will test and review this patch. Just a question, did you have a chance to test that this patch fix kernel crash? Best Regards, Konstantin Kostiuk. On Fri, Oct 25, 2024 at 1:06 PM Jean-Louis Dupond wrote: > On 9/10/2024 10:34, Jean-Lo

Re: [PATCH] qga: skip bind mounts in fs list

2024-10-25 Thread Jean-Louis Dupond
On 9/10/2024 10:34, Jean-Louis Dupond wrote: On 2/10/2024 12:06, Jean-Louis Dupond wrote: The filesystem list in build_fs_mount_list should skip bind mounts. This because we end up in locking situations when doing fsFreeze. Like mentioned in [1] and [2]. Next to that, the build_fs_mount_list ca

Re: [PATCH] qga: skip bind mounts in fs list

2024-10-09 Thread Jean-Louis Dupond
On 2/10/2024 12:06, Jean-Louis Dupond wrote: The filesystem list in build_fs_mount_list should skip bind mounts. This because we end up in locking situations when doing fsFreeze. Like mentioned in [1] and [2]. Next to that, the build_fs_mount_list call did a fallback via build_fs_mount_list_from

[PATCH] qga: skip bind mounts in fs list

2024-10-02 Thread Jean-Louis Dupond
The filesystem list in build_fs_mount_list should skip bind mounts. This because we end up in locking situations when doing fsFreeze. Like mentioned in [1] and [2]. Next to that, the build_fs_mount_list call did a fallback via build_fs_mount_list_from_mtab if mountinfo did not exist. There it skip