PR was sent
https://patchew.org/QEMU/20221026175518.2636846-1-kkost...@redhat.com/
On Wed, Oct 26, 2022 at 8:31 PM Konstantin Kostiuk
wrote:
> Reviewed-by: Konstantin Kostiuk
>
> On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman
> wrote:
>
>> It's useful to know which device was used if/when it fa
Reviewed-by: Konstantin Kostiuk
On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman
wrote:
> It's useful to know which device was used if/when it fails.
>
> channel-win32.c had this since 2015, with
> c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts to
> help troubleshoot installat
On Fri, 21 Oct 2022 at 08:53, Marc-André Lureau
wrote:
> [...]
> Wouldn't it be simpler to modify the g_critical() in ga_channel_new() instead?
>
> if (!ga_channel_open(c, path, method, listen_fd, &err)) {
> g_critical("Failed to open %s: %s", path, error_get_pretty(err));
Sounds like
Hi
On Fri, Oct 21, 2022 at 2:31 AM Bjørn Forsman
wrote:
> It's useful to know which device was used if/when it fails.
>
> channel-win32.c had this since 2015, with
> c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts to
> help troubleshoot installation"), this brings channel-pos
It's useful to know which device was used if/when it fails.
channel-win32.c had this since 2015, with
c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts to
help troubleshoot installation"), this brings channel-posix.c up to
speed.
Signed-off-by: Bjørn Forsman
---
qga/channel-po
