Re: [PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-17 Thread Daniel P . Berrangé
On Thu, Aug 17, 2023 at 12:47:48PM +0200, Denis V. Lunev wrote: > On 8/17/23 12:26, Daniel P. Berrangé wrote: > > On Thu, Aug 17, 2023 at 04:04:46AM +0800, Efim Shevrin via wrote: > > > From: Fima Shevrin > > > > > > When the guest OS starts, qemu-ga sends an event to the host. > > > This event a

Re: [PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-17 Thread Michael Tokarev
17.08.2023 13:26, Daniel P. Berrangé wrote: .. A host mgmt app should not be assuming that networking is running at all, and if it is, the guest might not even be on the same subnet as the host. Conceivably someone could even be using QGA to inject files to configure networking. Overall, IMHO, i

Re: [PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-17 Thread Denis V. Lunev
On 8/17/23 12:26, Daniel P. Berrangé wrote: On Thu, Aug 17, 2023 at 04:04:46AM +0800, Efim Shevrin via wrote: From: Fima Shevrin When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configur

Re: [PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-17 Thread Daniel P . Berrangé
On Thu, Aug 17, 2023 at 09:15:08AM +0300, Konstantin Kostiuk wrote: > Hi, Efim > > Thanks for your contribution. > > I think your patch is a partial solution because other network managers can > be used > for example systemd-networkd or dhcpcd. Maybe a better solution is > After=network.target.

Re: [PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-17 Thread Daniel P . Berrangé
On Thu, Aug 17, 2023 at 04:04:46AM +0800, Efim Shevrin via wrote: > From: Fima Shevrin > > When the guest OS starts, qemu-ga sends an event to the host. > This event allows services on the host to start configuring > the already running guest OS. When configuring network settings, > it is possibl

Re: [PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-16 Thread Konstantin Kostiuk
Hi, Efim Thanks for your contribution. I think your patch is a partial solution because other network managers can be used for example systemd-networkd or dhcpcd. Maybe a better solution is After=network.target. Do you have any other suggestions? Best Regards, Konstantin Kostiuk. On Wed, Aug

[PATCH] qga: Start qemu-ga service after NetworkManager start

2023-08-16 Thread Efim Shevrin via
From: Fima Shevrin When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configuring network settings, it is possible that an external service will receive a signal from qemu-ga about the start