Re: [PATCH] qga: Fix memory leak in split_list

2022-10-18 Thread Philippe Mathieu-Daudé
On 18/10/22 06:46, Miaoqian Lin wrote: We should use g_strfreev to free the memory allocated by g_strsplit(). Use g_free() will cause a memory leak. Signed-off-by: Miaoqian Lin --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 5a

Re: [PATCH] qga: Fix memory leak in split_list

2022-10-18 Thread Marc-André Lureau
Hi On Tue, Oct 18, 2022 at 8:47 AM Miaoqian Lin wrote: > We should use g_strfreev to free the memory allocated by g_strsplit(). > Use g_free() will cause a memory leak. > > Signed-off-by: Miaoqian Lin > --- > qga/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/q

Re: [PATCH] qga: Fix memory leak in split_list

2022-10-17 Thread Miaoqian Lin
Hi, On 2022/10/18 14:32, Marc-André Lureau wrote: > Hi > > On Tue, Oct 18, 2022 at 8:47 AM Miaoqian Lin wrote: > > We should use g_strfreev to free the memory allocated by g_strsplit(). > Use g_free() will cause a memory leak. > > Signed-off-by: Miaoqian Lin > --- >  qga/main

[PATCH] qga: Fix memory leak in split_list

2022-10-17 Thread Miaoqian Lin
We should use g_strfreev to free the memory allocated by g_strsplit(). Use g_free() will cause a memory leak. Signed-off-by: Miaoqian Lin --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 5a9d8252e075..04902076b25d 100644 --- a/qga/m