Re: [PATCH] qemu-nbd: Close inherited stderr

2020-05-13 Thread Raphael Pour
On 5/13/20 3:02 PM, Eric Blake wrote: > Yes, now that we know about it, the bug will be fixed in 5.1; we can > also cc: qemu-stable to get it backported to the next 5.0.x release > (downstream developers are also more likely to backport it to their > ports as well if it lands on qemu-stable).  Wo

Re: [PATCH] qemu-nbd: Close inherited stderr

2020-05-13 Thread Eric Blake
On 5/13/20 2:14 AM, Raphael Pour wrote: On 5/12/20 3:57 PM, Eric Blake wrote: Wouldn't it just be simpler to not dup in the first place? diff --git i/qemu-nbd.c w/qemu-nbd.c index 4aa005004ebd..6ba2544feb3a 100644 --- i/qemu-nbd.c +++ w/qemu-nbd.c @@ -916,7 +916,9 @@ int main(int argc, char **a

Re: [PATCH] qemu-nbd: Close inherited stderr

2020-05-13 Thread Raphael Pour
On 5/12/20 3:57 PM, Eric Blake wrote: > Wouldn't it just be simpler to not dup in the first place? > > diff --git i/qemu-nbd.c w/qemu-nbd.c > index 4aa005004ebd..6ba2544feb3a 100644 > --- i/qemu-nbd.c > +++ w/qemu-nbd.c > @@ -916,7 +916,9 @@ int main(int argc, char **argv) > } else if (pi

Re: [PATCH] qemu-nbd: Close inherited stderr

2020-05-12 Thread Eric Blake
Mon Sep 17 00:00:00 2001 From: "Raphael Pour" Date: Tue, 12 May 2020 10:18:44 +0200 Subject: [PATCH] qemu-nbd: Close inherited stderr Close inherited stderr of the parent if fork_process is false. Otherwise no one will close it. (introduced by e6df58a5) Signed-off-by: Raphael Pour

[PATCH] qemu-nbd: Close inherited stderr

2020-05-12 Thread Raphael Pour
phael Pour" Date: Tue, 12 May 2020 10:18:44 +0200 Subject: [PATCH] qemu-nbd: Close inherited stderr Close inherited stderr of the parent if fork_process is false. Otherwise no one will close it. (introduced by e6df58a5) Signed-off-by: Raphael Pour --- qemu-nbd.c | 9 - 1 file c