Re: [PATCH] qemu-iotests/iotests.py: improve assert_qmp message

2019-10-28 Thread Kevin Wolf
Am 26.10.2019 um 18:58 hat Vladimir Sementsov-Ogievskiy geschrieben: > 26.10.2019 14:29, Philippe Mathieu-Daudé wrote: > > On 10/26/19 12:12 PM, Vladimir Sementsov-Ogievskiy wrote: > >> Make it obvious, from the two values which is found at path and which > >> is expected. > > > > Maybe: > > > >

Re: [PATCH] qemu-iotests/iotests.py: improve assert_qmp message

2019-10-26 Thread Vladimir Sementsov-Ogievskiy
26.10.2019 14:29, Philippe Mathieu-Daudé wrote: > On 10/26/19 12:12 PM, Vladimir Sementsov-Ogievskiy wrote: >> Make it obvious, from the two values which is found at path and which >> is expected. > > Maybe: > > "From the two values compared, make it obvious which is found at path, and > which i

Re: [PATCH] qemu-iotests/iotests.py: improve assert_qmp message

2019-10-26 Thread Philippe Mathieu-Daudé
On 10/26/19 12:12 PM, Vladimir Sementsov-Ogievskiy wrote: Make it obvious, from the two values which is found at path and which is expected. Maybe: "From the two values compared, make it obvious which is found at path, and which is expected." Reviewed-by: Philippe Mathieu-Daudé Signed-o

[PATCH] qemu-iotests/iotests.py: improve assert_qmp message

2019-10-26 Thread Vladimir Sementsov-Ogievskiy
Make it obvious, from the two values which is found at path and which is expected. Signed-off-by: Vladimir Sementsov-Ogievskiy --- It's a pain, I can never remember it, and checking each time in source code who is who is boring. tests/qemu-iotests/iotests.py | 4 ++-- 1 file changed, 2 inserti