Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-14 Thread Hanna Reitz
On 19.08.21 12:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to the request alignment and where someone

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Vladimir Sementsov-Ogievskiy
07.09.2021 17:00, Hanna Reitz wrote: On 07.09.21 15:44, Vladimir Sementsov-Ogievskiy wrote: 07.09.2021 15:48, Hanna Reitz wrote: On 07.09.21 13:29, Vladimir Sementsov-Ogievskiy wrote: 19.08.2021 13:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to b

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Hanna Reitz
On 07.09.21 15:44, Vladimir Sementsov-Ogievskiy wrote: 07.09.2021 15:48, Hanna Reitz wrote: On 07.09.21 13:29, Vladimir Sementsov-Ogievskiy wrote: 19.08.2021 13:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the s

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Vladimir Sementsov-Ogievskiy
07.09.2021 15:48, Hanna Reitz wrote: On 07.09.21 13:29, Vladimir Sementsov-Ogievskiy wrote: 19.08.2021 13:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm()

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Hanna Reitz
On 07.09.21 13:29, Vladimir Sementsov-Ogievskiy wrote: 19.08.2021 13:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Vladimir Sementsov-Ogievskiy
19.08.2021 13:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to the request alignment and where someone

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Hanna Reitz
Ping – any thoughts on this? Hanna On 19.08.21 12:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to th

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-08-19 Thread Jose R. Ziviani
On Thu, Aug 19, 2021 at 05:14:30PM +0200, Hanna Reitz wrote: > On 19.08.21 16:31, Jose R. Ziviani wrote: > > Hello Hanna, > > > > On Thu, Aug 19, 2021 at 12:12:00PM +0200, Hanna Reitz wrote: > > > We cannot write to images opened with O_DIRECT unless we allow them to > > > be resized so they are a

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-08-19 Thread Hanna Reitz
On 19.08.21 16:31, Jose R. Ziviani wrote: Hello Hanna, On Thu, Aug 19, 2021 at 12:12:00PM +0200, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-08-19 Thread Jose R. Ziviani
Hello Hanna, On Thu, Aug 19, 2021 at 12:12:00PM +0200, Hanna Reitz wrote: > We cannot write to images opened with O_DIRECT unless we allow them to > be resized so they are aligned to the sector size: Since 9c60a5d1978, > bdrv_node_refresh_perm() ensures that for nodes whose length is not > aligned

[PATCH] qemu-img: Allow target be aligned to sector size

2021-08-19 Thread Hanna Reitz
We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to the request alignment and where someone has taken a WRITE permission, the RESIZ