Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-24 Thread Max Reitz
On 23.01.20 13:17, David Edmondson wrote: > On Tuesday, 2020-01-21 at 16:02:16 +01, Max Reitz wrote: > >> Hi, >> >> On 17.01.20 11:34, David Edmondson wrote: [...] >>> + >>> +if (!s->has_zero_init && s->target_is_new && s->min_sparse && >>> +!s->target_has_backing) { >> >> (This will

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-23 Thread David Edmondson
On Tuesday, 2020-01-21 at 16:02:16 +01, Max Reitz wrote: > Hi, > > On 17.01.20 11:34, David Edmondson wrote: >> In many cases the target of a convert operation is a newly provisioned >> target that the user knows is blank (filled with zeroes). In this >> situation there is no requirement for qemu-

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-21 Thread Max Reitz
Hi, On 17.01.20 11:34, David Edmondson wrote: > In many cases the target of a convert operation is a newly provisioned > target that the user knows is blank (filled with zeroes). In this > situation there is no requirement for qemu-img to wastefully zero out > the entire device. > > Add a new opt

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-21 Thread David Edmondson
On Monday, 2020-01-20 at 19:33:43 -05, John Snow wrote: > CC qemu-block and block maintainers > > On 1/17/20 5:34 AM, David Edmondson wrote: >> In many cases the target of a convert operation is a newly provisioned >> target that the user knows is blank (filled with zeroes). In this >> situation t

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-20 Thread John Snow
CC qemu-block and block maintainers On 1/17/20 5:34 AM, David Edmondson wrote: > In many cases the target of a convert operation is a newly provisioned > target that the user knows is blank (filled with zeroes). In this > situation there is no requirement for qemu-img to wastefully zero out > the

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread no-reply
: Add --target-is-zero to convert === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread no-reply
: Add --target-is-zero to convert === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT

[PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread David Edmondson
In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero, allowing the user to indicate that a

[PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread David Edmondson
In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero, allowing the user to indicate that a