Re: [PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-31 Thread Stefan Hajnoczi
On Wed, 31 Jul 2024 at 09:59, Peter Krempa wrote: > > On Tue, Jul 09, 2024 at 16:27:22 +0200, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > > > The QMP device_add monitor command converts the QDict arguments to > > > QemuOpts and then back again to QDict. This process only supports s

Re: [PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-31 Thread Peter Krempa
On Tue, Jul 09, 2024 at 16:27:22 +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > The QMP device_add monitor command converts the QDict arguments to > > QemuOpts and then back again to QDict. This process only supports scalar > > types. Device properties like virtio-blk-pci's iothr

Re: [PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-09 Thread Daniel P . Berrangé
On Mon, Jul 08, 2024 at 04:30:27PM +0200, Stefan Hajnoczi wrote: > The QMP device_add monitor command converts the QDict arguments to > QemuOpts and then back again to QDict. This process only supports scalar > types. Device properties like virtio-blk-pci's iothread-vq-mapping (an > array of object

Re: [PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-09 Thread Markus Armbruster
Stefan Hajnoczi writes: > The QMP device_add monitor command converts the QDict arguments to > QemuOpts and then back again to QDict. This process only supports scalar > types. Device properties like virtio-blk-pci's iothread-vq-mapping (an > array of objects) are silently dropped by qemu_opts_fr

[PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-08 Thread Stefan Hajnoczi
The QMP device_add monitor command converts the QDict arguments to QemuOpts and then back again to QDict. This process only supports scalar types. Device properties like virtio-blk-pci's iothread-vq-mapping (an array of objects) are silently dropped by qemu_opts_from_qdict() during the QemuOpts con