Re: [PATCH] qcow2: add discard-no-unref option

2023-06-02 Thread Hanna Czenczek
On 01.06.23 14:56, Jean-Louis Dupond wrote: On 31/05/2023 17:05, Hanna Czenczek wrote: On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's s/.

Re: [PATCH] qcow2: add discard-no-unref option

2023-06-01 Thread Jean-Louis Dupond
On 31/05/2023 17:16, Hanna Czenczek wrote: On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's that do a lot of writes/deletes. This causes th

Re: [PATCH] qcow2: add discard-no-unref option

2023-06-01 Thread Jean-Louis Dupond
On 31/05/2023 17:05, Hanna Czenczek wrote: On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's s/. Surely/, especially/ that do a lot of writ

Re: [PATCH] qcow2: add discard-no-unref option

2023-05-31 Thread Hanna Czenczek
On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's that do a lot of writes/deletes. This causes the qcow2 image to grow even over 110% of its virt

Re: [PATCH] qcow2: add discard-no-unref option

2023-05-31 Thread Hanna Czenczek
On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's s/. Surely/, especially/ that do a lot of writes/deletes. This causes the qcow2 image to gr

Re: [PATCH] qcow2: add discard-no-unref option

2023-05-31 Thread Hanna Czenczek
On 26.05.23 16:30, Jean-Louis Dupond wrote: On 26/05/2023 15:31, Hanna Czenczek wrote: [...] I don’t follow how this patch is cleaner than the “block: Add zeroes discard option” patch.  That patch’s diff stat is +14/-5, this one’s is 120+/57-. Multiple reasons :) - It's made for this use-c

Re: [PATCH] qcow2: add discard-no-unref option

2023-05-26 Thread Jean-Louis Dupond
On 26/05/2023 15:31, Hanna Czenczek wrote: On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's that do a lot of writes/deletes. This causes the

Re: [PATCH] qcow2: add discard-no-unref option

2023-05-26 Thread Hanna Czenczek
On 15.05.23 09:36, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's that do a lot of writes/deletes. This causes the qcow2 image to grow even over 110% of its virt

[PATCH] qcow2: add discard-no-unref option

2023-05-15 Thread Jean-Louis Dupond
When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's that do a lot of writes/deletes. This causes the qcow2 image to grow even over 110% of its virtual size, because the free gaps in the image g