Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-21 Thread Peter Xu
On Wed, Feb 21, 2024 at 09:30:52AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > Thanks, Markus. > > [...] > > > Reviewed-by: Peter Xu > > > > Markus, do you want us to pick it up, or let it go via qapi? > > I can stick it into my next qapi PR in a few days, if you guys don't > bea

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-21 Thread Markus Armbruster
Het Gala writes: > Sorry Markus, firstly I thought its just regarding qapi documentation so > migration maintainers might not be needed ? but then I realize the commit > message fails to specify that > > IIRC, you are one of the maintainers for qapi. So, just cc'd to you, but you > are right,

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-21 Thread Markus Armbruster
Peter Xu writes: > Thanks, Markus. [...] > Reviewed-by: Peter Xu > > Markus, do you want us to pick it up, or let it go via qapi? I can stick it into my next qapi PR in a few days, if you guys don't beat me to the punch.

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-21 Thread Peter Xu
Thanks, Markus. On Wed, Feb 21, 2024 at 12:36:57PM +0530, Het Gala wrote: > > > diff --git a/qapi/migration.json b/qapi/migration.json > > > index 5a565d9b8d..5756e650b0 100644 > > > --- a/qapi/migration.json > > > +++ b/qapi/migration.json > > > @@ -1728,6 +1728,7 @@ > > > # > > > # -> { "exe

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-20 Thread Het Gala
Sorry Markus, firstly I thought its just regarding qapi documentation so migration maintainers might not be needed ? but then I realize the commit message fails to specify that IIRC, you are one of the maintainers for qapi. So, just cc'd to you, but you are right, should have done to migration

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-20 Thread Markus Armbruster
You neglected to cc: migration maintainers; I'm doing that for you now. Peter or Fabiano, please have a look. Het Gala writes: > Signed-off-by: Het Gala > --- > qapi/migration.json | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/qapi/migration.json b/qap

[PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-16 Thread Het Gala
Signed-off-by: Het Gala --- qapi/migration.json | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 5a565d9b8d..5756e650b0 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1728,6 +1728,7 @@ # # -> { "exe