Re: [PATCH] q800: fix segfault with invalid MacROM

2022-01-07 Thread Laurent Vivier
Le 07/01/2022 à 10:47, BALATON Zoltan a écrit : On Fri, 7 Jan 2022, Laurent Vivier wrote: Le 07/01/2022 à 09:15, Mark Cave-Ayland a écrit : On 06/01/2022 12:22, Laurent Vivier wrote: "qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault in q800_init(). This happens because the co

Re: [PATCH] q800: fix segfault with invalid MacROM

2022-01-07 Thread BALATON Zoltan
On Fri, 7 Jan 2022, Laurent Vivier wrote: Le 07/01/2022 à 09:15, Mark Cave-Ayland a écrit : On 06/01/2022 12:22, Laurent Vivier wrote: "qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault in q800_init(). This happens because the code doesn't check that rom_ptr() returned a non-NU

Re: [PATCH] q800: fix segfault with invalid MacROM

2022-01-07 Thread Laurent Vivier
Le 07/01/2022 à 09:15, Mark Cave-Ayland a écrit : On 06/01/2022 12:22, Laurent Vivier wrote: "qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault in q800_init(). This happens because the code doesn't check that rom_ptr() returned a non-NULL pointer . Resolves: https://gitlab.com/

Re: [PATCH] q800: fix segfault with invalid MacROM

2022-01-07 Thread Mark Cave-Ayland
On 06/01/2022 12:22, Laurent Vivier wrote: "qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault in q800_init(). This happens because the code doesn't check that rom_ptr() returned a non-NULL pointer . Resolves: https://gitlab.com/qemu-project/qemu/-/issues/756 Reported-by: Peter M

Re: [PATCH] q800: fix segfault with invalid MacROM

2022-01-06 Thread Thomas Huth
On 06/01/2022 13.22, Laurent Vivier wrote: "qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault in q800_init(). This happens because the code doesn't check that rom_ptr() returned a non-NULL pointer . Resolves: https://gitlab.com/qemu-project/qemu/-/issues/756 Reported-by: Peter Ma

Re: [PATCH] q800: fix segfault with invalid MacROM

2022-01-06 Thread Philippe Mathieu-Daudé
On 6/1/22 13:22, Laurent Vivier wrote: "qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault Typo "crashes". in q800_init(). This happens because the code doesn't check that rom_ptr() returned a non-NULL pointer . Resolves: https://gitlab.com/qemu-project/qemu/-/issues/756 Repor

[PATCH] q800: fix segfault with invalid MacROM

2022-01-06 Thread Laurent Vivier
"qemu-system-m68k -M q800 -bios /dev/null" crahses with a segfault in q800_init(). This happens because the code doesn't check that rom_ptr() returned a non-NULL pointer . Resolves: https://gitlab.com/qemu-project/qemu/-/issues/756 Reported-by: Peter Maydell Signed-off-by: Laurent Vivier --- hw