Re: [PATCH] q35: catch invalid cpu hotplug configuration

2021-08-12 Thread Igor Mammedov
On Thu, 12 Aug 2021 12:23:41 +0200 Gerd Hoffmann wrote: > Related: https://bugzilla.redhat.com//show_bug.cgi?id=1985924 > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/isa/lpc_ich9.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/hw/isa/lpc_ich9

Re: [PATCH] q35: catch invalid cpu hotplug configuration

2021-08-12 Thread Gerd Hoffmann
Hi, > > +if ((lpc->smi_host_features & > > BIT_ULL(ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT)) && > > +!(lpc->smi_host_features & > > BIT_ULL(ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT))) { > > +/* > > + * smi_features_ok_callback() throws an error on this. > > + * > > +

Re: [PATCH] q35: catch invalid cpu hotplug configuration

2021-08-12 Thread Daniel P . Berrangé
On Thu, Aug 12, 2021 at 12:23:41PM +0200, Gerd Hoffmann wrote: > Related: https://bugzilla.redhat.com//show_bug.cgi?id=1985924 > Signed-off-by: Gerd Hoffmann > --- > hw/isa/lpc_ich9.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c >

[PATCH] q35: catch invalid cpu hotplug configuration

2021-08-12 Thread Gerd Hoffmann
Related: https://bugzilla.redhat.com//show_bug.cgi?id=1985924 Signed-off-by: Gerd Hoffmann --- hw/isa/lpc_ich9.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 5f9de0239cf9..5f143dca17aa 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lp