Re: [PATCH] python, tests: do not use short-form boolean options

2020-12-07 Thread John Snow
On 11/17/20 9:32 AM, Markus Armbruster wrote: Paolo Bonzini writes: On 17/11/20 10:20, Markus Armbruster wrote: -chardev = ('socket,id=console,path=%s,server,nowait' % +chardev = ('socket,id=console,path=%s,server=yes,wait=no' % Let's stick to the canonical 'on' and

Re: [PATCH] python, tests: do not use short-form boolean options

2020-11-17 Thread Markus Armbruster
Paolo Bonzini writes: > On 17/11/20 10:20, Markus Armbruster wrote: >>> -chardev = ('socket,id=console,path=%s,server,nowait' % >>> +chardev = ('socket,id=console,path=%s,server=yes,wait=no' % >> >> Let's stick to the canonical 'on' and 'off'. > > That was on purpose (for

Re: [PATCH] python, tests: do not use short-form boolean options

2020-11-17 Thread Paolo Bonzini
On 17/11/20 10:20, Markus Armbruster wrote: -chardev = ('socket,id=console,path=%s,server,nowait' % +chardev = ('socket,id=console,path=%s,server=yes,wait=no' % Let's stick to the canonical 'on' and 'off'. That was on purpose (for extra coverage and not just because va

Re: [PATCH] python, tests: do not use short-form boolean options

2020-11-17 Thread Markus Armbruster
Paolo Bonzini writes: > They are going to be deprecated, avoid warnings on stdout while the > tests run. > > Signed-off-by: Paolo Bonzini > --- > python/qemu/machine.py | 2 +- > tests/qtest/pflash-cfi02-test.c | 4 ++-- > tests/qtest/test-filter-redirector.c | 8 >

[PATCH] python, tests: do not use short-form boolean options

2020-11-13 Thread Paolo Bonzini
They are going to be deprecated, avoid warnings on stdout while the tests run. Signed-off-by: Paolo Bonzini --- python/qemu/machine.py | 2 +- tests/qtest/pflash-cfi02-test.c | 4 ++-- tests/qtest/test-filter-redirector.c | 8 tests/qtest/vhost-user-test.c| 8