Re: [PATCH] pseries: allow setting stdout-path even on machines with a VGA

2022-05-06 Thread Paolo Bonzini
On 5/6/22 00:10, Daniel Henrique Barboza wrote: Removing the negation seems to do what you want: -    if (!spapr->want_stdout_path && stdout_path) { +    if (spapr->want_stdout_path && stdout_path) { Yes, of course. Sorry! Paolo

Re: [PATCH] pseries: allow setting stdout-path even on machines with a VGA

2022-05-05 Thread Daniel Henrique Barboza
On 5/5/22 06:26, Paolo Bonzini wrote: -machine graphics=off is the usual way to tell the firmware or the OS that the user wants a serial console. The pseries machine however does not support this, and never adds the stdout-path node to the device tree if a VGA device is provided. This is in a

[PATCH] pseries: allow setting stdout-path even on machines with a VGA

2022-05-05 Thread Paolo Bonzini
-machine graphics=off is the usual way to tell the firmware or the OS that the user wants a serial console. The pseries machine however does not support this, and never adds the stdout-path node to the device tree if a VGA device is provided. This is in addition to the other magic behavior of VGA