Re: [PATCH] ppc: remove excessive logging

2019-12-16 Thread David Gibson
On Sun, Dec 15, 2019 at 11:59:22AM +0100, BALATON Zoltan wrote: > On Sun, 15 Dec 2019, Philippe Mathieu-Daudé wrote: > > Hi Joakim, > > > > I'm cc'ing the PPC maintainers for you, so they won't miss your patch > > (see > > https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer >

Re: [PATCH] ppc: remove excessive logging

2019-12-16 Thread da...@gibson.dropbear.id.au
On Mon, Dec 16, 2019 at 09:27:13AM +0100, Thomas Huth wrote: > On 15/12/2019 22.15, Joakim Tjernlund wrote: > [...] > >> LOG_EXCP() is not enabled by default, you have to edit source to enable it > > > > LOG_EXCP is enabled on Gentoo, what about other distros? > > I don't think that this is enabl

Re: [PATCH] ppc: remove excessive logging

2019-12-16 Thread Joakim Tjernlund
On Mon, 2019-12-16 at 09:27 +0100, Thomas Huth wrote: > > On 15/12/2019 22.15, Joakim Tjernlund wrote: > [...] > > > LOG_EXCP() is not enabled by default, you have to edit source to enable it > > > > LOG_EXCP is enabled on Gentoo, what about other distros? > > I don't think that this is enabled

Re: [PATCH] ppc: remove excessive logging

2019-12-16 Thread Thomas Huth
On 15/12/2019 22.15, Joakim Tjernlund wrote: [...] >> LOG_EXCP() is not enabled by default, you have to edit source to enable it > > LOG_EXCP is enabled on Gentoo, what about other distros? I don't think that this is enabled by any other distro. Why is this enabled on Gentoo at all? It really sho

Re: [PATCH] ppc: remove excessive logging

2019-12-15 Thread Joakim Tjernlund
On Sun, 2019-12-15 at 11:59 +0100, BALATON Zoltan wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Sun, 15 Dec 2019, Philippe Mathieu-Daudé wrote: > > Hi Jo

Re: [PATCH] ppc: remove excessive logging

2019-12-15 Thread BALATON Zoltan
On Sun, 15 Dec 2019, Philippe Mathieu-Daudé wrote: Hi Joakim, I'm cc'ing the PPC maintainers for you, so they won't miss your patch (see https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer and the output of ./scripts/get_maintainer.pl -f target/ppc/excp_helper.c). On 12/

Re: [PATCH] ppc: remove excessive logging

2019-12-14 Thread Philippe Mathieu-Daudé
Hi Joakim, I'm cc'ing the PPC maintainers for you, so they won't miss your patch (see https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer and the output of ./scripts/get_maintainer.pl -f target/ppc/excp_helper.c). On 12/14/19 1:13 PM, Joakim Tjernlund wrote: From: Joaki

Re: [PATCH] ppc: remove excessive logging

2019-12-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191214121347.17071-1-joakim.tjernl...@infinera.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] ppc: remove excessive logging Type: series Message-id: 20191214121347.17071-1

[PATCH] ppc: remove excessive logging

2019-12-14 Thread Joakim Tjernlund
From: Joakim Tjernlund ppc logs every type of Invalid instruction. This generates a lot of garbage on console when sshd/ssh_keygen executes as they try various insn to optimize its performance. The invalid operation log is still there so an unknown insn will still be logged. Signed-off-by: Joaki