Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-31 Thread Greg Kurz
On Tue, 30 Mar 2021 22:37:06 +0530 Vaibhav Jain wrote: > > Thanks for looking into this patch Greg. My responses below inline. > > > Greg Kurz writes: > > > Hi Vaibhav, > > > > Great to see you around :-) > > :-) > > > > > On Mon, 29 Mar 2021 21:52:59 +0530 > > Vaibhav Jain wrote: > > > >

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread Vaibhav Jain
Thanks for looking into this patch, David Gibson writes: >> H_SCM_HEALTH specifications is already documented in linux kernel >> documentation at >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst > > Putting a reference to that in t

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 10:37:06PM +0530, Vaibhav Jain wrote: > > Thanks for looking into this patch Greg. My responses below inline. > > > Greg Kurz writes: > > > Hi Vaibhav, > > > > Great to see you around :-) > > :-) > > > > > On Mon, 29 Mar 2021 21:52:59 +0530 > > Vaibhav Jain wrote: >

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread Vaibhav Jain
Thanks for looking into this patch Greg. My responses below inline. Greg Kurz writes: > Hi Vaibhav, > > Great to see you around :-) :-) > > On Mon, 29 Mar 2021 21:52:59 +0530 > Vaibhav Jain wrote: > >> Add support for H_SCM_HEALTH hcall described at [1] for spapr >> nvdimms. This enables g

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread Greg Kurz
Hi Vaibhav, Great to see you around :-) On Mon, 29 Mar 2021 21:52:59 +0530 Vaibhav Jain wrote: > Add support for H_SCM_HEALTH hcall described at [1] for spapr > nvdimms. This enables guest to detect the 'unarmed' status of a > specific spapr nvdimm identified by its DRC and if its unarmed, mark

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread Vaibhav Jain
Hi Shiva, Thanks for reviweing this patch. My responses inline below; Shivaprasad G Bhat writes: >> >> +static target_ulong h_scm_health(PowerPCCPU *cpu, SpaprMachineState *spapr, >> + target_ulong opcode, target_ulong *args) >> +{ >> +uint32_t drc_inde

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-29 Thread Shivaprasad G Bhat
Hi Vaibhav, Some comments inline.. On 3/29/21 9:52 PM, Vaibhav Jain wrote: Add support for H_SCM_HEALTH hcall described at [1] for spapr nvdimms. This enables guest to detect the 'unarmed' status of a specific spapr nvdimm identified by its DRC and if its unarmed, mark the region backed by the

[PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-29 Thread Vaibhav Jain
Add support for H_SCM_HEALTH hcall described at [1] for spapr nvdimms. This enables guest to detect the 'unarmed' status of a specific spapr nvdimm identified by its DRC and if its unarmed, mark the region backed by the nvdimm as read-only. The patch adds h_scm_health() to handle the H_SCM_HEALTH