Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-09 Thread Aaron Lindsay via
On Mar 09 17:45, Alex Bennée wrote: > Aaron Lindsay writes: > > On Mar 09 10:08, Peter Maydell wrote: > >> On Mon, 8 Mar 2021 at 20:14, Aaron Lindsay > >> wrote: > >> > > >> > This allows plugins to query for full virtual-to-physical address > >> > translation for a given `qemu_plugin_hwaddr` an

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-09 Thread Alex Bennée
Aaron Lindsay writes: > On Mar 09 10:08, Peter Maydell wrote: >> On Mon, 8 Mar 2021 at 20:14, Aaron Lindsay >> wrote: >> > >> > This allows plugins to query for full virtual-to-physical address >> > translation for a given `qemu_plugin_hwaddr` and stops exposing the >> > offset within the dev

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-09 Thread Aaron Lindsay
On Mar 09 10:08, Peter Maydell wrote: > On Mon, 8 Mar 2021 at 20:14, Aaron Lindsay > wrote: > > > > This allows plugins to query for full virtual-to-physical address > > translation for a given `qemu_plugin_hwaddr` and stops exposing the > > offset within the device itself. As this change breaks

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-09 Thread Alex Bennée
Aaron Lindsay writes: > Alex, > > I've now tested this change, and it is giving what appear to be valid > and correct physical addresses for both RAM and IO accesses in all the > cases I've thrown at it. My main concern with this patch at this point > is that I am concerned I may be breaking yo

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-09 Thread Peter Maydell
On Mon, 8 Mar 2021 at 20:14, Aaron Lindsay wrote: > > This allows plugins to query for full virtual-to-physical address > translation for a given `qemu_plugin_hwaddr` and stops exposing the > offset within the device itself. As this change breaks the API, > QEMU_PLUGIN_VERSION is incremented. > >

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-08 Thread no-reply
] plugins: Expose physical addresses instead of device offsets === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback b

[PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-08 Thread Aaron Lindsay
This allows plugins to query for full virtual-to-physical address translation for a given `qemu_plugin_hwaddr` and stops exposing the offset within the device itself. As this change breaks the API, QEMU_PLUGIN_VERSION is incremented. Signed-off-by: Aaron Lindsay --- contrib/plugins/hotpages.c |

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-08 Thread Aaron Lindsay
Alex, I've now tested this change, and it is giving what appear to be valid and correct physical addresses for both RAM and IO accesses in all the cases I've thrown at it. My main concern with this patch at this point is that I am concerned I may be breaking your new plugin here: > +++ b/contrib/