Re: [PATCH] physmem: replace assertion with error

2025-02-18 Thread Gupta, Pankaj
On 2/17/2025 1:08 PM, Paolo Bonzini wrote: It is possible to start QEMU with a confidential-guest-support object even in TCG mode. While there is already a check in qemu_machine_creation_done: if (machine->cgs && !machine->cgs->ready) { error_setg(errp, "accelerator does not suppo

Re: [PATCH] physmem: replace assertion with error

2025-02-18 Thread David Hildenbrand
On 17.02.25 13:08, Paolo Bonzini wrote: It is possible to start QEMU with a confidential-guest-support object even in TCG mode. While there is already a check in qemu_machine_creation_done: if (machine->cgs && !machine->cgs->ready) { error_setg(errp, "accelerator does not support

Re: [PATCH] physmem: replace assertion with error

2025-02-17 Thread Xiaoyao Li
On 2/17/2025 8:08 PM, Paolo Bonzini wrote: It is possible to start QEMU with a confidential-guest-support object even in TCG mode. While there is already a check in qemu_machine_creation_done: if (machine->cgs && !machine->cgs->ready) { error_setg(errp, "accelerator does not suppo

[PATCH] physmem: replace assertion with error

2025-02-17 Thread Paolo Bonzini
It is possible to start QEMU with a confidential-guest-support object even in TCG mode. While there is already a check in qemu_machine_creation_done: if (machine->cgs && !machine->cgs->ready) { error_setg(errp, "accelerator does not support confidential guest %s", o

Re: [PATCH] physmem: replace assertion with error

2025-02-17 Thread Paolo Bonzini
On Mon, Feb 17, 2025 at 1:28 PM Philippe Mathieu-Daudé wrote: > qemu-system-x86_64 -m 512 -nographic -object sev-snp-guest,reduced-phys-bits=48,id=sev0 \ > -M q35,kernel-irqchip=split,confidential-guest-support=sev0 > qemu-system-x86_64: ../system/physmem.c:1871: ram_block

Re: [PATCH] physmem: replace assertion with error

2025-02-17 Thread Daniel P . Berrangé
On Mon, Feb 17, 2025 at 01:08:12PM +0100, Paolo Bonzini wrote: > It is possible to start QEMU with a confidential-guest-support object > even in TCG mode. While there is already a check in > qemu_machine_creation_done: > > if (machine->cgs && !machine->cgs->ready) { > error_setg(errp

Re: [PATCH] physmem: replace assertion with error

2025-02-17 Thread Philippe Mathieu-Daudé
Hi Paolo, On 17/2/25 13:08, Paolo Bonzini wrote: It is possible to start QEMU with a confidential-guest-support object even in TCG mode. While there is already a check in qemu_machine_creation_done: if (machine->cgs && !machine->cgs->ready) { error_setg(errp, "accelerator does no