Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-21 Thread Michael S. Tsirkin
On Wed, Feb 19, 2020 at 01:21:10PM +0100, Julia Suvorova wrote: > On Wed, Feb 19, 2020 at 4:47 AM Michael S. Tsirkin wrote: > > > > On Tue, Feb 18, 2020 at 10:02:19PM -0500, Laine Stump wrote: > > > Also, is there a rhyme/reason for some options having true/false, and some > > > being off/on? disa

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-21 Thread Daniel P . Berrangé
On Tue, Feb 18, 2020 at 12:18:04PM -0500, Laine Stump wrote: > On 2/18/20 11:17 AM, Julia Suvorova wrote: > > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt > > to manage it and restrict unplug for the entire machine. This is going > > to prevent user-initiated unplug in gues

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-19 Thread Julia Suvorova
On Wed, Feb 19, 2020 at 4:47 AM Michael S. Tsirkin wrote: > > On Tue, Feb 18, 2020 at 10:02:19PM -0500, Laine Stump wrote: > > Also, is there a rhyme/reason for some options having true/false, and some > > being off/on? disable-acs seems to be true/false, but disable-modern is > > on/off. Doesn't

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Michael S. Tsirkin
On Tue, Feb 18, 2020 at 10:02:19PM -0500, Laine Stump wrote: > Also, is there a rhyme/reason for some options having true/false, and some > being off/on? disable-acs seems to be true/false, but disable-modern is > on/off. Doesn't make any difference to me in the end, but just thought I'd > bring it

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Laine Stump
On 2/18/20 1:40 PM, Julia Suvorova wrote: On Tue, Feb 18, 2020 at 6:18 PM Laine Stump wrote: On 2/18/20 11:17 AM, Julia Suvorova wrote: Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt to manage it and restrict unplug for the entire machine. This is going to prevent user-

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Julia Suvorova
On Tue, Feb 18, 2020 at 6:18 PM Laine Stump wrote: > > On 2/18/20 11:17 AM, Julia Suvorova wrote: > > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt > > to manage it and restrict unplug for the entire machine. This is going > > to prevent user-initiated unplug in guests (Win

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Ján Tomko
On Tue, Feb 18, 2020 at 05:17:17PM +0100, Julia Suvorova wrote: Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt to manage it and restrict unplug for the entire machine. This is going to prevent user-initiated unplug in guests (Windows mostly). Usage: -device pcie-root-por

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Laine Stump
On 2/18/20 11:17 AM, Julia Suvorova wrote: Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt to manage it and restrict unplug for the entire machine. This is going to prevent user-initiated unplug in guests (Windows mostly). Usage: -device pcie-root-port,disable-hotplug=t

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Igor Mammedov
On Tue, 18 Feb 2020 17:17:17 +0100 Julia Suvorova wrote: > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt > to manage it and restrict unplug for the entire machine. This is going > to prevent user-initiated unplug in guests (Windows mostly). > Usage: > -device pcie-root

[PATCH] pcie_root_port: Add disable_hotplug option

2020-02-18 Thread Julia Suvorova
Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt to manage it and restrict unplug for the entire machine. This is going to prevent user-initiated unplug in guests (Windows mostly). Usage: -device pcie-root-port,disable-hotplug=true,... Discussion related: https://lists