Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Vladimir Sementsov-Ogievskiy
On 25.04.23 15:10, Gerd Hoffmann wrote: On Tue, Apr 25, 2023 at 03:26:50AM -0400, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: On migration, on target we load local ROM file. But actual ROM content migrates through migration channel. Or

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Gerd Hoffmann
Hi, > > If you supply your own versions for some reason you must make sure > > they have identical size on all host machines. > > on my ubuntu 22.04: > > dpkg -L ipxe-qemu | grep efi-virtio > /usr/lib/ipxe/qemu/efi-virtio.rom > > ls -lthr /usr/lib/ipxe/qemu/efi-virtio.rom > -rw-r--r-- 1 roo

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Michael S. Tsirkin
On Tue, Apr 25, 2023 at 11:34:09AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 25.04.23 10:43, Michael S. Tsirkin wrote: > > On Tue, Apr 25, 2023 at 03:26:54AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > On

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Igor Mammedov
On Tue, 25 Apr 2023 13:55:55 +0300 Vladimir Sementsov-Ogievskiy wrote: > On 24.04.23 23:36, Vladimir Sementsov-Ogievskiy wrote: > > On migration, on target we load local ROM file. But actual ROM content > > migrates through migration channel. Original ROM content from local > > file doesn't matte

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Gerd Hoffmann
On Tue, Apr 25, 2023 at 03:26:50AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On migration, on target we load local ROM file. But actual ROM content > > migrates through migration channel. Original ROM content from local > >

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 23:36, Vladimir Sementsov-Ogievskiy wrote: On migration, on target we load local ROM file. But actual ROM content migrates through migration channel. Original ROM content from local file doesn't matter. But when size mismatch - we have an error like Size mismatch: :00:03.0/virt

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Laszlo Ersek
On 4/25/23 09:26, Michael S. Tsirkin wrote: > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> On migration, on target we load local ROM file. But actual ROM content >> migrates through migration channel. Original ROM content from local >> file doesn't matter. But wh

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Vladimir Sementsov-Ogievskiy
On 25.04.23 10:43, Michael S. Tsirkin wrote: On Tue, Apr 25, 2023 at 03:26:54AM -0400, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: On migration, on target we load local ROM file. But actual ROM content migrates through migration channe

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Michael S. Tsirkin
On Tue, Apr 25, 2023 at 03:26:54AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On migration, on target we load local ROM file. But actual ROM content > > migrates through migration channel. Original ROM content from local > >

Re: [PATCH] pci: make ROM memory resizable

2023-04-25 Thread Michael S. Tsirkin
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On migration, on target we load local ROM file. But actual ROM content > migrates through migration channel. Original ROM content from local > file doesn't matter. But when size mismatch - we have an error like > > Si

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 25.04.23 00:06, Michael S. Tsirkin wrote: On Tue, Apr 25, 2023 at 12:02:49AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 24.04.23 23:45, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sements

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Michael S. Tsirkin
On Tue, Apr 25, 2023 at 12:02:49AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 24.04.23 23:45, Michael S. Tsirkin wrote: > > On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: > > > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > On

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 23:45, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: On migration, on target we load local ROM file. But actual ROM content migrates through migration channe

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 23:41, Michael S. Tsirkin wrote: @@ -2366,7 +2368,8 @@ static void pci_add_option_rom(PCIDevice *pdev, bool is_default_rom, snprintf(name, sizeof(name), "%s.rom", object_get_typename(OBJECT(pdev))); } pdev->has_rom = true; -memory_region_init_rom(&pdev->rom

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On migration, on target we load local ROM file. But actual ROM content > > migrates through migration channel. Original ROM content from local > >

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On migration, on target we load local ROM file. But actual ROM content > migrates through migration channel. Original ROM content from local > file doesn't matter. But when size mismatch - we have an error like > > Si

[PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On migration, on target we load local ROM file. But actual ROM content migrates through migration channel. Original ROM content from local file doesn't matter. But when size mismatch - we have an error like Size mismatch: :00:03.0/virtio-net-pci.rom: 0x4 != 0x8: Invalid argument Let