Re: [PATCH] oss-fuzz: move linker arg to fix coverage-build

2020-09-10 Thread Darren Kenny
On Thursday, 2020-09-10 at 12:36:52 -04, Alexander Bulekov wrote: > On 200910 1645, Darren Kenny wrote: >> Hi Alex, >> >> I'm certainly not an expert in meson, but have some questions below... >> >> On Wednesday, 2020-09-09 at 18:05:16 -04, Alexander Bulekov wrote: >> > The order of the add_proje

Re: [PATCH] oss-fuzz: move linker arg to fix coverage-build

2020-09-10 Thread Alexander Bulekov
On 200910 1645, Darren Kenny wrote: > Hi Alex, > > I'm certainly not an expert in meson, but have some questions below... > > On Wednesday, 2020-09-09 at 18:05:16 -04, Alexander Bulekov wrote: > > The order of the add_project_link_arguments calls impacts which > > arguments are placed between --s

Re: [PATCH] oss-fuzz: move linker arg to fix coverage-build

2020-09-10 Thread Darren Kenny
Hi Alex, I'm certainly not an expert in meson, but have some questions below... On Wednesday, 2020-09-09 at 18:05:16 -04, Alexander Bulekov wrote: > The order of the add_project_link_arguments calls impacts which > arguments are placed between --start-group and --end-group. > OSS-Fuzz coverage bu

[PATCH] oss-fuzz: move linker arg to fix coverage-build

2020-09-09 Thread Alexander Bulekov
The order of the add_project_link_arguments calls impacts which arguments are placed between --start-group and --end-group. OSS-Fuzz coverage builds seem to just add these to CFLAGS: -fprofile-instr-generate -fcoverage-mapping pthread -Wl,--no-as-needed --Wl,-ldl -Wl,-lm Wno-unused-command-line-arg