Re: [PATCH] nvme: fix bit buckets

2022-04-25 Thread Keith Busch
On Mon, Apr 25, 2022 at 11:59:30AM +0200, Klaus Jensen wrote: > The approach is neat and simple, but I don't think it has the intended > effect. The memory region addr is just left at 0x0, so we just end up > with mapping that directly into the qsg and in my test setup, this > basically does DMA to

Re: [PATCH] nvme: fix bit buckets

2022-04-25 Thread Klaus Jensen
+qemu-devel On Apr 22 09:37, Keith Busch wrote: > We can't just ignore the bit buckets since the data offsets read from > disk need to be accounted for. We could either split into multiple reads > for the actual user data requested and skip the buckets, or we could > have a place holder for bucket