Re: [PATCH] netmap: support git-submodule build otption

2019-10-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Oct 07, 2019 at 01:39:30PM +0100, Peter Maydell wrote: >> On Mon, 7 Oct 2019 at 13:36, Markus Armbruster wrote: >> > If CI of QEMU code isn't useful, then I suspect the QEMU code isn't >> > useful, period. Giuseppe assures us the netmap QEMU code *is* useful

Re: [PATCH] netmap: support git-submodule build otption

2019-10-08 Thread Daniel P . Berrangé
On Mon, Oct 07, 2019 at 01:39:30PM +0100, Peter Maydell wrote: > On Mon, 7 Oct 2019 at 13:36, Markus Armbruster wrote: > > If CI of QEMU code isn't useful, then I suspect the QEMU code isn't > > useful, period. Giuseppe assures us the netmap QEMU code *is* useful. > > It followe we better make su

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Markus Armbruster
Thomas Huth writes: > On 07/10/2019 14.35, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: Peter Maydell writes: > Basically new submodules are a pain so we seek to minimize > the use of them. I suggested ma

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: >> Peter Maydell writes: >> > Basically new submodules are a pain so we seek to minimize >> > the use of them. >> >> I suggested making it a submodule upthread[*]. Let me try to distill >> the conversation into a rat

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Thomas Huth
On 07/10/2019 14.35, Markus Armbruster wrote: > Peter Maydell writes: > >> On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: >>> Peter Maydell writes: Basically new submodules are a pain so we seek to minimize the use of them. >>> >>> I suggested making it a submodule upthread[*].

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Peter Maydell
On Mon, 7 Oct 2019 at 13:36, Markus Armbruster wrote: > If CI of QEMU code isn't useful, then I suspect the QEMU code isn't > useful, period. Giuseppe assures us the netmap QEMU code *is* useful. > It followe we better make sure our CI covers it. It would be an interesting idea to have a require

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: >> Peter Maydell writes: >> > Basically new submodules are a pain so we seek to minimize >> > the use of them. >> >> I suggested making it a submodule upthread[*]. Let me try to distill >> the conversation into a rat

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Peter Maydell
On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: > Peter Maydell writes: > > Basically new submodules are a pain so we seek to minimize > > the use of them. > > I suggested making it a submodule upthread[*]. Let me try to distill > the conversation into a rationale. Giuseppe, please correc

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Markus Armbruster
Peter Maydell writes: D> On Fri, 4 Oct 2019 at 14:03, Giuseppe Lettieri wrote: >> >> From: Giuseppe Lettieri >> >> With this patch, netmap support can be enabled with >> the following options to the configure script: >> >> --enable-netmap[=system] >> >> Use the host system netmap ins

[PATCH] netmap: support git-submodule build otption

2019-10-04 Thread Giuseppe Lettieri
From: Giuseppe Lettieri With this patch, netmap support can be enabled with the following options to the configure script: --enable-netmap[=system] Use the host system netmap installation. Fail if not found. --enable-netmap=git clone the official netmap repository

Re: [PATCH] netmap: support git-submodule build otption

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 14:03, Giuseppe Lettieri wrote: > > From: Giuseppe Lettieri > > With this patch, netmap support can be enabled with > the following options to the configure script: > > --enable-netmap[=system] > > Use the host system netmap installation. > Fail if not foun