Re: [PATCH] net: Complete qapi-fication of netdev_add

2020-03-17 Thread Markus Armbruster
Eric Blake writes: > We've had all the required pieces for doing a type-safe representation > of netdev_add as a flat union for quite some time now (since > 0e55c381f6 in v2.7.0, released in 2016), but did not make the final > switch to using it because of concern about whether a command-line > r

Re: [PATCH] net: Complete qapi-fication of netdev_add

2020-03-16 Thread Markus Armbruster
Markus Armbruster writes: [...] > We better check all other uses of option group "netdev". To the best of my grepping abilities: = Definition = * qemu_netdev_opts Option group definition, with empty .desc[]. = CLI = Keep in mind: we finish processing CLI netdev before we start monitors (w

Re: [PATCH] net: Complete qapi-fication of netdev_add

2020-03-13 Thread Markus Armbruster
It's too late in my day for a full review. Just one observation for now. Eric Blake writes: > We've had all the required pieces for doing a type-safe representation > of netdev_add as a flat union for quite some time now (since > 0e55c381f6 in v2.7.0, released in 2016), but did not make the fin

[PATCH] net: Complete qapi-fication of netdev_add

2020-03-12 Thread Eric Blake
We've had all the required pieces for doing a type-safe representation of netdev_add as a flat union for quite some time now (since 0e55c381f6 in v2.7.0, released in 2016), but did not make the final switch to using it because of concern about whether a command-line regression in accepting "1" in p