[PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-10-12 Thread Peter Maydell
In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header so that it was always included from .c files and never from other .h files. We missed adding it to net/tap-solaris.c (which previously was pulling it in via tap-int.h), which broke building on Solaris hosts. Fixes: a8d25326

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-07 Thread Laurent Vivier
Le 07/07/2020 à 17:23, Michele Denber a écrit : > > > On 07/06/20 13:04, Laurent Vivier wrote: >> Le 04/07/2020 à 20:13, Michele Denber a écrit : >>> On 07/04/20 13:11, Thomas Huth wrote: On 04/07/2020 11.23, Peter Maydell wrote: > In commit a8d2532645cf5ce4 we cleaned up usage of the qe

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-07 Thread Michele Denber
On 07/06/20 13:04, Laurent Vivier wrote: Le 04/07/2020 à 20:13, Michele Denber a écrit : On 07/04/20 13:11, Thomas Huth wrote: On 04/07/2020 11.23, Peter Maydell wrote: In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header so that it was always included from .c files an

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-06 Thread Laurent Vivier
Le 06/07/2020 à 19:56, Philippe Mathieu-Daudé a écrit : > On Mon, Jul 6, 2020 at 7:30 PM Laurent Vivier wrote: >> Le 04/07/2020 à 20:13, Michele Denber a écrit : >>> On 07/04/20 13:11, Thomas Huth wrote: On 04/07/2020 11.23, Peter Maydell wrote: > In commit a8d2532645cf5ce4 we cleaned up

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-06 Thread Philippe Mathieu-Daudé
On Mon, Jul 6, 2020 at 7:30 PM Laurent Vivier wrote: > Le 04/07/2020 à 20:13, Michele Denber a écrit : > > On 07/04/20 13:11, Thomas Huth wrote: > >> On 04/07/2020 11.23, Peter Maydell wrote: > >>> In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header > >>> so that it was alwa

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-06 Thread Laurent Vivier
Le 04/07/2020 à 20:13, Michele Denber a écrit : > On 07/04/20 13:11, Thomas Huth wrote: >> On 04/07/2020 11.23, Peter Maydell wrote: >>> In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header >>> so that it was always included from .c files and never from other .h files. >>> We

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-04 Thread Michele Denber
On 07/04/20 13:11, Thomas Huth wrote: On 04/07/2020 11.23, Peter Maydell wrote: In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header so that it was always included from .c files and never from other .h files. We missed adding it to net/tap-solaris.c (which previously was pu

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-04 Thread Thomas Huth
On 04/07/2020 11.23, Peter Maydell wrote: > In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header > so that it was always included from .c files and never from other .h files. > We missed adding it to net/tap-solaris.c (which previously was pulling it > in via tap-int.h), which

Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/4/20 11:23 AM, Peter Maydell wrote: > In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header > so that it was always included from .c files and never from other .h files. > We missed adding it to net/tap-solaris.c (which previously was pulling it > in via tap-int.h), which

[PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

2020-07-04 Thread Peter Maydell
In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header so that it was always included from .c files and never from other .h files. We missed adding it to net/tap-solaris.c (which previously was pulling it in via tap-int.h), which broke building on Solaris hosts. Fixes: a8d25326