Re: [PATCH] net/tap: drop too small packets

On Tue, Jul 15, 2025 at 10:59 PM Vladimir Sementsov-Ogievskiy wrote: > > On 14.07.25 05:12, Jason Wang wrote: > > On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> On 07.07.25 06:49, Jason Wang wrote: > >>> On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin > >>> wro

Re: [PATCH] net/tap: drop too small packets

On 14.07.25 05:12, Jason Wang wrote: On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy wrote: On 07.07.25 06:49, Jason Wang wrote: On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: Theoretically tap_read_packet() may

Re: [PATCH] net/tap: drop too small packets

On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy wrote: > > On 07.07.25 06:49, Jason Wang wrote: > > On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin > > wrote: > >> > >> On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: > >> > >>> Theoretically tap_read_packet() may return size l

Re: [PATCH] net/tap: drop too small packets

On 07.07.25 06:49, Jason Wang wrote: On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: Theoretically tap_read_packet() may return size less than s->host_vnet_hdr_len, and next, we'll work with negative size (in case of !s->using_vne

Re: [PATCH] net/tap: drop too small packets

On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: > > On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: > > > Theoretically tap_read_packet() may return size less than > > s->host_vnet_hdr_len, and next, we'll work with negative size > > (in case of !s->using_vnet_hdr). Let's avoid it. >

Re: [PATCH] net/tap: drop too small packets

I tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: > > On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: > > > Theoretically tap_read_packet() may return size less than > > s->host_vnet_hdr

Re: [PATCH] net/tap: drop too small packets

On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: Theoretically tap_read_packet() may return size less than s->host_vnet_hdr_len, and next, we'll work with negative size (in case of !s->using_vnet_hdr). Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 5 +

[PATCH] net/tap: drop too small packets

Theoretically tap_read_packet() may return size less than s->host_vnet_hdr_len, and next, we'll work with negative size (in case of !s->using_vnet_hdr). Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/tap.c b/