Re: [PATCH] migration: do not restart VM after successful snapshot-load

2021-05-04 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapsh

Re: [PATCH] migration: do not restart VM after successful snapshot-load

2021-05-04 Thread Daniel P . Berrangé
On Tue, May 04, 2021 at 12:58:26PM -0400, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot

Re: [PATCH] migration: do not restart VM after successful snapshot-load

2021-05-04 Thread Eric Blake
On 5/4/21 11:58 AM, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapshot_l

[PATCH] migration: do not restart VM after successful snapshot-load

2021-05-04 Thread Paolo Bonzini
The HMP loadvm code is calling load_snapshot rather than qmp_snapshot_load, in order to bypass the job infrastructure. The code around it is almost the same, with one difference: hmp_loadvm is restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so if load_snapshot succeeds. Fix t