Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 12:43:42PM -0400, Peter Xu wrote: > On Thu, Apr 18, 2024 at 06:47:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On 18.04.24 18:43, Daniel P. Berrangé wrote: > > > On Thu, Apr 18, 2024 at 06:40:38PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > On 18.04.24 1

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Peter Xu
On Thu, Apr 18, 2024 at 06:47:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 18.04.24 18:43, Daniel P. Berrangé wrote: > > On Thu, Apr 18, 2024 at 06:40:38PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 18.04.24 17:37, Daniel P. Berrangé wrote: > > > > On Thu, Apr 18, 2024 at 01:1

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Vladimir Sementsov-Ogievskiy
On 18.04.24 18:43, Daniel P. Berrangé wrote: On Thu, Apr 18, 2024 at 06:40:38PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 18.04.24 17:37, Daniel P. Berrangé wrote: On Thu, Apr 18, 2024 at 01:13:29AM +0300, Vladimir Sementsov-Ogievskiy wrote: We do set MIGRATION_FAILED state, but don't give

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 06:40:38PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 18.04.24 17:37, Daniel P. Berrangé wrote: > > On Thu, Apr 18, 2024 at 01:13:29AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > We do set MIGRATION_FAILED state, but don't give a chance to > > > orchestrator t

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Vladimir Sementsov-Ogievskiy
On 18.04.24 17:37, Daniel P. Berrangé wrote: On Thu, Apr 18, 2024 at 01:13:29AM +0300, Vladimir Sementsov-Ogievskiy wrote: We do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's report an error through QAPI like we do on outgo

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Vladimir Sementsov-Ogievskiy
On 18.04.24 17:27, Fabiano Rosas wrote: Vladimir Sementsov-Ogievskiy writes: We do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's report an error through QAPI like we do on outgoing migration. migration-test is updated co

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 01:13:29AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We do set MIGRATION_FAILED state, but don't give a chance to > orchestrator to query migration state and get the error. > > Let's report an error through QAPI like we do on outgoing migration. > > migration-test is up

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > We do set MIGRATION_FAILED state, but don't give a chance to > orchestrator to query migration state and get the error. > > Let's report an error through QAPI like we do on outgoing migration. > > migration-test is updated correspondingly. > > Signed-off-by:

[PATCH] migration: do not exit on incoming failure

2024-04-17 Thread Vladimir Sementsov-Ogievskiy
We do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's report an error through QAPI like we do on outgoing migration. migration-test is updated correspondingly. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Doubt: is exitin