Re: [PATCH] migration: Ensure vmstate_save() sets errp

2024-10-15 Thread Hanna Czenczek
On 15.10.24 18:06, Peter Xu wrote: On Tue, Oct 15, 2024 at 04:15:15PM +0200, Hanna Czenczek wrote: migration/savevm.c contains some calls to vmstate_save() that are followed by migrate_set_error() if the integer return value indicates an error. migrate_set_error() requires that the `Error *` ob

Re: [PATCH] migration: Ensure vmstate_save() sets errp

2024-10-15 Thread Peter Xu
On Tue, Oct 15, 2024 at 04:15:15PM +0200, Hanna Czenczek wrote: > migration/savevm.c contains some calls to vmstate_save() that are > followed by migrate_set_error() if the integer return value indicates an > error. migrate_set_error() requires that the `Error *` object passed to > it is set. The

[PATCH] migration: Ensure vmstate_save() sets errp

2024-10-15 Thread Hanna Czenczek
migration/savevm.c contains some calls to vmstate_save() that are followed by migrate_set_error() if the integer return value indicates an error. migrate_set_error() requires that the `Error *` object passed to it is set. Therefore, vmstate_save() is assumed to always set *errp on error. Right n