Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-28 Thread Avihai Horon
On 28/02/2024 12:17, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, Feb 28, 2024 at 11:39:52AM +0200, Avihai Horon wrote: On 28/02/2024 5:04, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, Feb 28, 2024 at 02:00:26AM +0200

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-28 Thread Peter Xu
On Wed, Feb 28, 2024 at 11:39:52AM +0200, Avihai Horon wrote: > > On 28/02/2024 5:04, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, Feb 28, 2024 at 02:00:26AM +0200, Avihai Horon wrote: > > > On 27/02/2024 9:41, Peter Xu wrote: > > > > External

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-28 Thread Avihai Horon
On 27/02/2024 5:16, Wang, Lei wrote: External email: Use caution opening links or attachments On 2/22/2024 23:56, Avihai Horon wrote: Currently, migration code serializes device data sending during pre-copy iterative phase. As noted in the code comment, this is done to prevent faster changin

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-28 Thread Avihai Horon
On 28/02/2024 5:04, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, Feb 28, 2024 at 02:00:26AM +0200, Avihai Horon wrote: On 27/02/2024 9:41, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Feb 22, 2024 at 05:56:27PM +0200,

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-27 Thread Peter Xu
On Wed, Feb 28, 2024 at 02:00:26AM +0200, Avihai Horon wrote: > > On 27/02/2024 9:41, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, Feb 22, 2024 at 05:56:27PM +0200, Avihai Horon wrote: > > > Currently, migration code serializes device data send

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-27 Thread Avihai Horon
On 27/02/2024 9:41, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Feb 22, 2024 at 05:56:27PM +0200, Avihai Horon wrote: Currently, migration code serializes device data sending during pre-copy iterative phase. As noted in the code comment, this is done to p

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-27 Thread Joao Martins
On 27/02/2024 07:41, Peter Xu wrote: > On Thu, Feb 22, 2024 at 05:56:27PM +0200, Avihai Horon wrote: >> This bug was observed in several VFIO migration scenarios where some >> workload on the VM prevented RAM from ever reaching a hard zero, not >> allowing VFIO initial pre-copy data to be sent, and

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-26 Thread Peter Xu
On Thu, Feb 22, 2024 at 05:56:27PM +0200, Avihai Horon wrote: > Currently, migration code serializes device data sending during pre-copy > iterative phase. As noted in the code comment, this is done to prevent > faster changing device from sending its data over and over. Frankly speaking I don't u

Re: [PATCH] migration: Don't serialize migration while can't switchover

2024-02-26 Thread Wang, Lei
On 2/22/2024 23:56, Avihai Horon wrote: > Currently, migration code serializes device data sending during pre-copy > iterative phase. As noted in the code comment, this is done to prevent > faster changing device from sending its data over and over. > > However, with switchover-ack capability enab

[PATCH] migration: Don't serialize migration while can't switchover

2024-02-22 Thread Avihai Horon
Currently, migration code serializes device data sending during pre-copy iterative phase. As noted in the code comment, this is done to prevent faster changing device from sending its data over and over. However, with switchover-ack capability enabled, this behavior can be problematic and may prev