Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Peter Xu
On Tue, Oct 22, 2024 at 01:40:37PM +0200, Markus Armbruster wrote: > If we want such warnings for QMP, they should be automated just like the > -compat actions. Any existing warnings rendered redundant should then > be taken out. I considered that when I did -compat, and rejected it as > not wort

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Oct 22, 2024 at 12:37:46PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, Oct 22, 2024 at 10:41:29AM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > Per previous discussion [1,2], this patch deprecates >

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Daniel P . Berrangé
On Tue, Oct 22, 2024 at 12:37:46PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Oct 22, 2024 at 10:41:29AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > Per previous discussion [1,2], this patch deprecates > >> > query-migrationthreads > >> > c

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Oct 22, 2024 at 10:41:29AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Per previous discussion [1,2], this patch deprecates query-migrationthreads >> > command. >> > >> > To summarize, the major reason of the deprecation is due to no sensible

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Daniel P . Berrangé
On Tue, Oct 22, 2024 at 10:41:29AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Per previous discussion [1,2], this patch deprecates query-migrationthreads > > command. > > > > To summarize, the major reason of the deprecation is due to no sensible way > > to consume the API properly:

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Markus Armbruster
Peter Xu writes: > Per previous discussion [1,2], this patch deprecates query-migrationthreads > command. > > To summarize, the major reason of the deprecation is due to no sensible way > to consume the API properly: > > (1) The reported list of threads are incomplete (ignoring destination >

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-22 Thread Daniel P . Berrangé
On Mon, Oct 21, 2024 at 05:52:20PM -0400, Peter Xu wrote: > Per previous discussion [1,2], this patch deprecates query-migrationthreads > command. > > To summarize, the major reason of the deprecation is due to no sensible way > to consume the API properly: > > (1) The reported list of threads

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-21 Thread Prasad Pandit
On Tue, 22 Oct 2024 at 03:22, Peter Xu wrote: > To summarize, the major reason of the deprecation is due to no sensible way > to consume the API properly: > > (1) The reported list of threads are incomplete (ignoring destination > threads and non-multifd threads). > > (2) For CPU pinning

Re: [PATCH] migration: Deprecate query-migrationthreads command

2024-10-21 Thread Fabiano Rosas
Peter Xu writes: > Per previous discussion [1,2], this patch deprecates query-migrationthreads > command. > > To summarize, the major reason of the deprecation is due to no sensible way > to consume the API properly: > > (1) The reported list of threads are incomplete (ignoring destination >

[PATCH] migration: Deprecate query-migrationthreads command

2024-10-21 Thread Peter Xu
Per previous discussion [1,2], this patch deprecates query-migrationthreads command. To summarize, the major reason of the deprecation is due to no sensible way to consume the API properly: (1) The reported list of threads are incomplete (ignoring destination threads and non-multifd threa