Re: [PATCH] migration/savevm: release gslist after dump_vmstate_json

2020-02-27 Thread Philippe Mathieu-Daudé
Correcting Zhang email. On 2/19/20 10:47 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan 'list' forgot to free at the end of dump_vmstate_json_to_file(), although it's called only once, but seems like a clean code. Fix the leak as follow: Direct leak of 16 byte(s) in 1 object(s) allocat

Re: [PATCH] migration/savevm: release gslist after dump_vmstate_json

2020-02-27 Thread Philippe Mathieu-Daudé
On 2/19/20 10:59 AM, Dr. David Alan Gilbert wrote: * pannengy...@huawei.com (pannengy...@huawei.com) wrote: From: Pan Nengyuan 'list' forgot to free at the end of dump_vmstate_json_to_file(), although it's called only once, but seems like a clean code. Fix the leak as follow: Direct leak of

Re: [PATCH] migration/savevm: release gslist after dump_vmstate_json

2020-02-27 Thread Juan Quintela
wrote: > From: Pan Nengyuan > > 'list' forgot to free at the end of dump_vmstate_json_to_file(), although > it's called only once, but seems like a clean code. > > Fix the leak as follow: > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x7fb946abd768 in __interceptor_malloc (

Re: [PATCH] migration/savevm: release gslist after dump_vmstate_json

2020-02-19 Thread Dr. David Alan Gilbert
* pannengy...@huawei.com (pannengy...@huawei.com) wrote: > From: Pan Nengyuan > > 'list' forgot to free at the end of dump_vmstate_json_to_file(), although > it's called only once, but seems like a clean code. > > Fix the leak as follow: > Direct leak of 16 byte(s) in 1 object(s) allocated from

[PATCH] migration/savevm: release gslist after dump_vmstate_json

2020-02-19 Thread pannengyuan
From: Pan Nengyuan 'list' forgot to free at the end of dump_vmstate_json_to_file(), although it's called only once, but seems like a clean code. Fix the leak as follow: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7fb946abd768 in __interceptor_malloc (/lib64/libasan.so.5+0x