Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Peter Xu
On Tue, Feb 11, 2020 at 09:22:00AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Feb 10, 2020 at 07:44:59PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > rdma_accept_incoming_migration is called from an

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > rdma_accept_incoming_migration is called from an fd handler and > > can't return an Error * anywhere. > > Currently it's leaking Error's in errp/local_err - there's > >

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > rdma_accept_incoming_migration is called from an fd handler and > can't return an Error * anywhere. > Currently it's leaking Error's in errp/local_err - there's > no point putting them in there unless we can report them. >

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Feb 10, 2020 at 07:44:59PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > rdma_accept_incoming_migration is called from an fd handler and > > can't return an Error * anywhere. > > Currently it's leaking Error's

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-10 Thread Peter Xu
On Mon, Feb 10, 2020 at 07:44:59PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > rdma_accept_incoming_migration is called from an fd handler and > can't return an Error * anywhere. > Currently it's leaking Error's in errp/local_err - there's > no point putting th

[PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" rdma_accept_incoming_migration is called from an fd handler and can't return an Error * anywhere. Currently it's leaking Error's in errp/local_err - there's no point putting them in there unless we can report them. Turn most into fprintf's, and the last into an err