Re: [PATCH] meson.build: don't condition iconv detection on library detection

2020-10-15 Thread Paolo Bonzini
On 15/10/20 00:19, Bruce Rogers wrote: > It isn't necessarily the case that use of iconv requires an additional > library. For that reason we shouldn't conditionalize iconv detection on > libiconv.found. > > Fixes: 5285e593c33 (configure: Fixes ncursesw detection under msys2/mingw by > convert th

Re: [PATCH] meson.build: don't condition iconv detection on library detection

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/15/20 6:33 AM, 罗勇刚(Yonggang Luo) wrote: On Thu, Oct 15, 2020 at 6:19 AM Bruce Rogers > wrote: > > It isn't necessarily the case that use of iconv requires an additional > library. For that reason we shouldn't conditionalize iconv detection on > libiconv.found

Re: [PATCH] meson.build: don't condition iconv detection on library detection

2020-10-14 Thread Yonggang Luo
On Thu, Oct 15, 2020 at 6:19 AM Bruce Rogers wrote: > > It isn't necessarily the case that use of iconv requires an additional > library. For that reason we shouldn't conditionalize iconv detection on > libiconv.found. > > Fixes: 5285e593c33 (configure: Fixes ncursesw detection under msys2/mingw b

[PATCH] meson.build: don't condition iconv detection on library detection

2020-10-14 Thread Bruce Rogers
It isn't necessarily the case that use of iconv requires an additional library. For that reason we shouldn't conditionalize iconv detection on libiconv.found. Fixes: 5285e593c33 (configure: Fixes ncursesw detection under msys2/mingw by convert them to meson) Signed-off-by: Bruce Rogers --- mes